fix: Check record equality before generating diff (#1123)

candiduslynx · web-flow · commit b2e63318befa · 2023-08-01T13:51:31.000Z
1. Less data generated
2. Allows to account for unordered map keys (foe CH, for example)
diff --git a/plugin/diff.go b/plugin/diff.go
@@ -9,6 +9,9 @@ import (
 )
 
 func RecordDiff(l, r arrow.Record) string {
+	if array.RecordApproxEqual(l, r, array.WithUnorderedMapKeys(true)) {
+		return ""
+	}
 	var sb strings.Builder
 	if l.NumCols() != r.NumCols() {
 		return fmt.Sprintf("different number of columns: %d vs %d", l.NumCols(), r.NumCols())

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,9 @@ import (`
`9`	`9`	`)`
`10`	`10`
`11`	`11`	`func RecordDiff(l, r arrow.Record) string {`
	`12`	`+ if array.RecordApproxEqual(l, r, array.WithUnorderedMapKeys(true)) {`
	`13`	`+ return ""`
	`14`	`+ }`
`12`	`15`	`var sb strings.Builder`
`13`	`16`	`if l.NumCols() != r.NumCols() {`
`14`	`17`	`return fmt.Sprintf("different number of columns: %d vs %d", l.NumCols(), r.NumCols())`