Skip to content

Commit b33c777

Browse files
authored
feat: Change default source tables to none (#790)
Long overdue - changing default of synced tables to none. Especially in big plugins users should choose what they want to sync as it affect performance, throttles and price.
1 parent 9562727 commit b33c777

File tree

2 files changed

+0
-5
lines changed

2 files changed

+0
-5
lines changed

specs/source.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,6 @@ func (s *Source) SetDefaults() {
6464
if s.Scheduler.String() == "" {
6565
s.Scheduler = SchedulerDFS
6666
}
67-
if s.Tables == nil {
68-
s.Tables = []string{"*"}
69-
}
7067

7168
if s.TableConcurrency != 0 || s.ResourceConcurrency != 0 {
7269
// attempt to make a sensible backwards-compatible choice, but the CLI

specs/source_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,6 @@ spec:
136136
Path: "cloudquery/test",
137137
Concurrency: defaultConcurrency,
138138
Version: "v1.1.0",
139-
Tables: []string{"*"},
140139
Destinations: []string{"test"},
141140
Scheduler: SchedulerRoundRobin,
142141
},
@@ -157,7 +156,6 @@ spec:
157156
Path: "cloudquery/test",
158157
Concurrency: defaultConcurrency,
159158
Version: "v1.1.0",
160-
Tables: []string{"*"},
161159
Destinations: []string{"test"},
162160
Scheduler: SchedulerDFS,
163161
},

0 commit comments

Comments
 (0)