fix(writers): Don't export defaults (#1013)

Author: disq

writers/batchwriter/batchwriter.go

@@ -71,14 +71,20 @@ type worker struct {
 	flush chan chan bool
 }
 
+const (
+	defaultBatchTimeoutSeconds = 20
+	defaultBatchSize           = 10000
+	defaultBatchSizeBytes      = 5 * 1024 * 1024 // 5 MiB
+)
+
 func New(client Client, opts ...Option) (*BatchWriter, error) {
 	c := &BatchWriter{
 		client:         client,
 		workers:        make(map[string]*worker),
 		logger:         zerolog.Nop(),
-		batchTimeout:   writers.DefaultBatchTimeoutSeconds * time.Second,
-		batchSize:      writers.DefaultBatchSize,
-		batchSizeBytes: writers.DefaultBatchSizeBytes,
+		batchTimeout:   defaultBatchTimeoutSeconds * time.Second,
+		batchSize:      defaultBatchSize,
+		batchSizeBytes: defaultBatchSizeBytes,
 	}
 	for _, opt := range opts {
 		opt(c)

writers/mixedbatchwriter/mixedbatchwriter.go

@@ -46,12 +46,18 @@ func WithBatchSizeBytes(size int) Option {
 	}
 }
 
+const (
+	defaultBatchTimeoutSeconds = 20
+	defaultBatchSize           = 10000
+	defaultBatchSizeBytes      = 5 * 1024 * 1024 // 5 MiB
+)
+
 func New(client Client, opts ...Option) (*MixedBatchWriter, error) {
 	c := &MixedBatchWriter{
 		client:         client,
 		logger:         zerolog.Nop(),
-		batchSize:      writers.DefaultBatchSize,
-		batchSizeBytes: writers.DefaultBatchSizeBytes,
+		batchSize:      defaultBatchSize,
+		batchSizeBytes: defaultBatchSizeBytes,
 	}
 	for _, opt := range opts {
 		opt(c)

writers/streamingbatchwriter/streamingbatchwriter.go

@@ -101,14 +101,20 @@ func withTimerFn(timer timerFn) Option {
 	}
 }
 
+const (
+	defaultBatchTimeoutSeconds = 20
+	defaultBatchSize           = 10000
+	defaultBatchSizeBytes      = 5 * 1024 * 1024 // 5 MiB
+)
+
 func New(client Client, opts ...Option) (*StreamingBatchWriter, error) {
 	c := &StreamingBatchWriter{
 		client:         client,
 		insertWorkers:  make(map[string]*streamingWorkerManager[*message.WriteInsert]),
 		logger:         zerolog.Nop(),
-		batchTimeout:   writers.DefaultBatchTimeoutSeconds * time.Second,
-		batchSizeRows:  writers.DefaultBatchSize,
-		batchSizeBytes: writers.DefaultBatchSizeBytes,
+		batchTimeout:   defaultBatchTimeoutSeconds * time.Second,
+		batchSizeRows:  defaultBatchSize,
+		batchSizeBytes: defaultBatchSizeBytes,
 		timerFn:        timer,
 	}
 	for _, opt := range opts {

writers/writers.go

@@ -9,9 +9,3 @@ import (
 type Writer interface {
 	Write(ctx context.Context, res <-chan message.WriteMessage) error
 }
-
-const (
-	DefaultBatchTimeoutSeconds = 20
-	DefaultBatchSize           = 10000
-	DefaultBatchSizeBytes      = 5 * 1024 * 1024 // 5 MiB
-)