fix: Validate missing PK components

Author: erezrokah

schema/resource.go

@@ -126,16 +126,21 @@ func (r *Resource) storeCQID(value uuid.UUID) error {
 // Validates that all primary keys have values.
 func (r *Resource) Validate() error {
 	var missingPks []string
+	var missingPKComponents []string
 	for i, c := range r.Table.Columns {
-		if c.PrimaryKey {
-			if !r.data[i].IsValid() {
-				missingPks = append(missingPks, c.Name)
-			}
+		switch {
+		case c.PrimaryKey && !r.data[i].IsValid():
+			missingPks = append(missingPks, c.Name)
+		case c.PrimaryKeyComponent && !r.data[i].IsValid():
+			missingPKComponents = append(missingPKComponents, c.Name)
 		}
 	}
 	if len(missingPks) > 0 {
 		return fmt.Errorf("missing primary key on columns: %v", missingPks)
 	}
+	if len(missingPKComponents) > 0 {
+		return fmt.Errorf("missing primary key component on columns: %v", missingPKComponents)
+	}
 	return nil
 }
 

schema/resource_test.go

@@ -0,0 +1,63 @@
+package schema
+
+import (
+	"errors"
+	"testing"
+
+	"github.com/apache/arrow-go/v18/arrow"
+	"github.com/stretchr/testify/require"
+)
+
+func TestResource_Validate(t *testing.T) {
+	tests := []struct {
+		name        string
+		resource    *Resource
+		valueSetter func(resource *Resource) error
+		err         error
+	}{
+		{
+			name:     "valid resource without primary keys or primary key components",
+			resource: NewResourceData(&Table{Name: "test", Columns: ColumnList{{Name: "col1", Type: arrow.BinaryTypes.String}}}, nil, nil),
+			err:      nil,
+		},
+		{
+			name:     "valid resource with primary keys",
+			resource: NewResourceData(&Table{Name: "test", Columns: ColumnList{{Name: "col1", Type: arrow.BinaryTypes.String, PrimaryKey: true}}}, nil, nil),
+			err:      nil,
+			valueSetter: func(resource *Resource) error {
+				return resource.Set("col1", "test")
+			},
+		},
+		{
+			name:     "valid resource with primary key components",
+			resource: NewResourceData(&Table{Name: "test", Columns: ColumnList{{Name: "col1", Type: arrow.BinaryTypes.String, PrimaryKeyComponent: true}}}, nil, nil),
+			err:      nil,
+			valueSetter: func(resource *Resource) error {
+				return resource.Set("col1", "test")
+			},
+		},
+		{
+			name:     "invalid resource with primary keys",
+			resource: NewResourceData(&Table{Name: "test", Columns: ColumnList{{Name: "col1", Type: arrow.BinaryTypes.String, PrimaryKey: true}}}, nil, nil),
+			err:      errors.New(`missing primary key on columns: [col1]`),
+		},
+		{
+			name:     "invalid resource with primary key components",
+			resource: NewResourceData(&Table{Name: "test", Columns: ColumnList{{Name: "col1", Type: arrow.BinaryTypes.String, PrimaryKeyComponent: true}}}, nil, nil),
+			err:      errors.New(`missing primary key component on columns: [col1]`),
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if tt.valueSetter != nil {
+				require.NoError(t, tt.valueSetter(tt.resource))
+			}
+			validationError := tt.resource.Validate()
+			if tt.err == nil {
+				require.NoError(t, validationError)
+			} else {
+				require.ErrorContains(t, validationError, tt.err.Error())
+			}
+		})
+	}
+}