Skip to content

Commit f21e963

Browse files
authored
fix(package): Don't init destinations during package (#1249)
Fixes #1248 Another option that we could do (or do both) is handle `NoConnection` in all destinations. ---
1 parent db3c420 commit f21e963

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

serve/package.go

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -308,12 +308,13 @@ func (s *PluginServe) newCmdPluginPackage() *cobra.Command {
308308
if err := os.MkdirAll(distPath, 0755); err != nil {
309309
return err
310310
}
311-
if err := s.plugin.Init(cmd.Context(), nil, plugin.NewClientOptions{
312-
NoConnection: true,
313-
}); err != nil {
314-
return err
315-
}
311+
316312
if pluginKind == plugin.KindSource {
313+
if err := s.plugin.Init(cmd.Context(), nil, plugin.NewClientOptions{
314+
NoConnection: true,
315+
}); err != nil {
316+
return err
317+
}
317318
if err := s.writeTablesJSON(cmd.Context(), distPath); err != nil {
318319
return err
319320
}

0 commit comments

Comments
 (0)