Skip to content

Commit f565da8

Browse files
authored
fix: MixedBatchWriter should nil the slice instead of zeroing (#1553)
Helps with memory. Benched with #1552, old: ``` BenchmarkWriterMemory/MixedBatchWriter_batch10k_bytes100M BenchmarkWriterMemory/MixedBatchWriter_batch10k_bytes100M-10 826 1445595 ns/op 1393 bytes/op BenchmarkWriterMemory/MixedBatchWriter_defaults BenchmarkWriterMemory/MixedBatchWriter_defaults-10 670 1504799 ns/op 1393 bytes/op BenchmarkWriterMemory/MixedBatchWriter_wide_batch10k_bytes100M BenchmarkWriterMemory/MixedBatchWriter_wide_batch10k_bytes100M-10 8 128966609 ns/op 172785 bytes/op BenchmarkWriterMemory/MixedBatchWriter_wide_defaults BenchmarkWriterMemory/MixedBatchWriter_wide_defaults-10 9 118630315 ns/op 60355 bytes/op ``` new: ``` BenchmarkWriterMemory/MixedBatchWriter_batch10k_bytes100M BenchmarkWriterMemory/MixedBatchWriter_batch10k_bytes100M-10 690 1476479 ns/op 1401 bytes/op BenchmarkWriterMemory/MixedBatchWriter_defaults BenchmarkWriterMemory/MixedBatchWriter_defaults-10 687 1539707 ns/op 1401 bytes/op BenchmarkWriterMemory/MixedBatchWriter_wide_batch10k_bytes100M BenchmarkWriterMemory/MixedBatchWriter_wide_batch10k_bytes100M-10 8 129154755 ns/op 173592 bytes/op BenchmarkWriterMemory/MixedBatchWriter_wide_defaults BenchmarkWriterMemory/MixedBatchWriter_wide_defaults-10 9 111416773 ns/op 44588 bytes/op ```
1 parent d907120 commit f565da8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

writers/mixedbatchwriter/mixedbatchwriter.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ func (m *batchManager[A, T]) flush(ctx context.Context) error {
192192
if err != nil {
193193
return err
194194
}
195-
m.batch = m.batch[:0]
195+
m.batch = nil
196196
return nil
197197
}
198198

@@ -229,7 +229,7 @@ func (m *insertBatchManager) flush(ctx context.Context) error {
229229
}
230230
m.logger.Debug().Int("len", batchSize).Dur("duration", time.Since(start)).Msg("batch written successfully")
231231

232-
m.batch = m.batch[:0]
232+
m.batch = nil
233233
m.curBatchSizeBytes = 0
234234
return nil
235235
}

0 commit comments

Comments
 (0)