fix(testdata): Don't use escaping in JSON testdata (as array.Approx will check the underlying data) (#898)

candiduslynx · web-flow · commit f7e0ae7bbf52 · 2023-05-22T13:52:14.000Z
diff --git a/schema/testdata.go b/schema/testdata.go
@@ -319,9 +319,9 @@ func getExampleJSON(colName string, dataType arrow.DataType, opts GenTestDataOpt
 	}
 	if arrow.TypeEqual(dataType, types.ExtensionTypes.JSON) {
 		if strings.HasSuffix(colName, "_array") {
-			return `"[{\"test\":\"test\"},123,{\"test_number\":456}]"`
+			return `[{"test":"test"},123,{"test_number":456}]`
 		}
-		return `"{\"test\":[\"a\",\"b\",3]}"`
+		return `{"test":["a","b",3]}`
 	}
 	if arrow.TypeEqual(dataType, types.ExtensionTypes.Inet) {
 		return `"192.0.2.0/24"`

Original file line number	Diff line number	Diff line change
`@@ -319,9 +319,9 @@ func getExampleJSON(colName string, dataType arrow.DataType, opts GenTestDataOpt`
`319`	`319`	`}`
`320`	`320`	`if arrow.TypeEqual(dataType, types.ExtensionTypes.JSON) {`
`321`	`321`	`if strings.HasSuffix(colName, "_array") {`
`322`		- return `"[{\"test\":\"test\"},123,{\"test_number\":456}]"`
	`322`	+ return `[{"test":"test"},123,{"test_number":456}]`
`323`	`323`	`}`
`324`		- return `"{\"test\":[\"a\",\"b\",3]}"`
	`324`	+ return `{"test":["a","b",3]}`
`325`	`325`	`}`
`326`	`326`	`if arrow.TypeEqual(dataType, types.ExtensionTypes.Inet) {`
`327`	`327`	return `"192.0.2.0/24"`