Skip to content

Commit fde9e36

Browse files
committed
Do atomic.LoadUint even though it should not be needed
1 parent 1f69f24 commit fde9e36

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

scheduler/queue/worker.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,9 @@ func (w *worker) resolveTable(ctx context.Context, table *schema.Table, client s
8282
tableMetrics := w.metrics.TableClient[table.Name][clientName]
8383
defer func() {
8484
span.AddEvent("sync.finish.stats", trace.WithAttributes(
85-
attribute.Key("sync.resources").Int64(int64(tableMetrics.Resources)),
86-
attribute.Key("sync.errors").Int64(int64(tableMetrics.Errors)),
87-
attribute.Key("sync.panics").Int64(int64(tableMetrics.Panics)),
85+
attribute.Key("sync.resources").Int64(int64(atomic.LoadUint64(&tableMetrics.Resources))),
86+
attribute.Key("sync.errors").Int64(int64(atomic.LoadUint64(&tableMetrics.Errors))),
87+
attribute.Key("sync.panics").Int64(int64(atomic.LoadUint64(&tableMetrics.Panics))),
8888
))
8989
}()
9090
tableMetrics.OtelStartTime(ctx, startTime)

scheduler/scheduler_dfs.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,9 @@ func (s *syncClient) resolveTableDfs(ctx context.Context, table *schema.Table, c
9595
tableMetrics := s.metrics.TableClient[table.Name][clientName]
9696
defer func() {
9797
span.AddEvent("sync.finish.stats", trace.WithAttributes(
98-
attribute.Key("sync.resources").Int64(int64(tableMetrics.Resources)),
99-
attribute.Key("sync.errors").Int64(int64(tableMetrics.Errors)),
100-
attribute.Key("sync.panics").Int64(int64(tableMetrics.Panics)),
98+
attribute.Key("sync.resources").Int64(int64(atomic.LoadUint64(&tableMetrics.Resources))),
99+
attribute.Key("sync.errors").Int64(int64(atomic.LoadUint64(&tableMetrics.Errors))),
100+
attribute.Key("sync.panics").Int64(int64(atomic.LoadUint64(&tableMetrics.Panics))),
101101
))
102102
}()
103103
tableMetrics.OtelStartTime(ctx, startTime)

0 commit comments

Comments
 (0)