fix: improve naming

Author: jsilll

src/core/__tests__/chart-core-legend.test.tsx

@@ -453,13 +453,13 @@ describe("CoreChart: legend", () => {
     });
   });
 
-  test("calls onLegendHover when hovering over a legend item", () => {
-    const onLegendHover = vi.fn();
-    const { wrapper } = renderChart({ highcharts, options: { series }, onLegendHover });
+  test("calls onLegendItemHighlight when hovering over a legend item", () => {
+    const onLegendItemHighlight = vi.fn();
+    const { wrapper } = renderChart({ highcharts, options: { series }, onLegendItemHighlight });
 
     hoverLegendItem(0, wrapper);
 
-    expect(onLegendHover).toHaveBeenCalledWith(
+    expect(onLegendItemHighlight).toHaveBeenCalledWith(
       expect.objectContaining({
         item: expect.objectContaining({
           id: "L1",

src/core/__tests__/common.tsx

@@ -33,7 +33,7 @@ export function StatefulChart(props: CoreChartProps) {
 }
 
 type TestProps = Partial<CoreChartProps> & {
-  onLegendHover?: () => void;
+  onLegendItemHighlight?: () => void;
   i18nProvider?: Record<string, Record<string, string>>;
 };
 

src/core/chart-core.tsx

@@ -58,7 +58,7 @@ export function InternalCoreChart({
   filter,
   keyboardNavigation = true,
   onHighlight,
-  onLegendHover,
+  onLegendItemHighlight,
   onClearHighlight,
   onVisibleItemsChange,
   visibleItems,
@@ -308,7 +308,7 @@ export function InternalCoreChart({
               position={legendPosition}
               api={api}
               i18nStrings={i18nStrings}
-              onItemHover={onLegendHover}
+              onItemHighlight={onLegendItemHighlight}
               getLegendTooltipContent={rest.getLegendTooltipContent}
             />
           ) : null

src/core/components/core-legend.tsx

@@ -14,15 +14,15 @@ export function ChartLegend({
   actions,
   position,
   i18nStrings,
-  onItemHover,
+  onItemHighlight,
   getLegendTooltipContent,
 }: {
   api: ChartAPI;
   title?: string;
   actions?: React.ReactNode;
   position: "bottom" | "side";
   i18nStrings?: BaseI18nStrings;
-  onItemHover?: (detail: CoreChartProps.LegendHoverDetail) => void;
+  onItemHighlight?: (detail: CoreChartProps.LegendHoverDetail) => void;
   getLegendTooltipContent?: CoreChartProps.GetLegendTooltipContent;
 }) {
   const i18n = useInternalI18n("[charts]");
@@ -44,7 +44,7 @@ export function ChartLegend({
       onItemHighlightExit={api.onClearChartItemsHighlight}
       onItemHighlightEnter={(item) => {
         api.onHighlightChartItems([item.id]);
-        onItemHover?.({ item });
+        onItemHighlight?.({ item });
       }}
       getTooltipContent={(props) => {
         if (isChartTooltipPinned) {

src/core/interfaces.ts

@@ -342,9 +342,9 @@ export interface CoreChartProps
    */
   visibleItems?: readonly string[];
   /**
-   * Called when the user hovers over a legend item.
+   * Called when a legend item is highlighted.
    */
-  onLegendHover?: (detail: CoreChartProps.LegendHoverDetail) => void;
+  onLegendItemHighlight?: (detail: CoreChartProps.LegendHoverDetail) => void;
   /**
    * Called when series/points visibility changes due to user interaction with legend or filter.
    */