Remove unnecessary functions

jperals · jperals · commit e81fa893d510 · 2025-12-23T09:47:24.000+01:00
diff --git a/pages/02-pie-chart/controlled-visibility.page.tsx b/pages/02-pie-chart/controlled-visibility.page.tsx
@@ -2,14 +2,17 @@
 // SPDX-License-Identifier: Apache-2.0
 
 import { PieChart, PieChartProps } from "../../lib/components";
-import sum from "../../lib/components/internal/sum";
 import { PageSettings, PageSettingsForm, SeriesFilter, useChartSettings } from "../common/page-settings";
 import { Page, PageSection } from "../common/templates";
 
 interface ThisPageSettings extends PageSettings {
   visibleItems: string;
 }
 
+function sum(array: number[]): number {
+  return array.reduce((acc, val) => acc + val, 0);
+}
+
 const pieChartSeries: PieChartProps.SeriesOptions = {
   name: "Value",
   type: "pie",
diff --git a/pages/03-core/core-dual-axis-chart.page.tsx b/pages/03-core/core-dual-axis-chart.page.tsx
@@ -3,11 +3,11 @@
 
 import Link from "@cloudscape-design/components/link";
 
-import omit from "../../lib/components/internal/utils/omit";
 import CoreChart from "../../lib/components/internal-do-not-use/core-chart";
 import { dateFormatter } from "../common/formatters";
 import { PageSettingsForm, useChartSettings } from "../common/page-settings";
 import { Page } from "../common/templates";
+import omit from "../utils/omit";
 import pseudoRandom from "../utils/pseudo-random";
 
 function randomInt(min: number, max: number) {
diff --git a/pages/03-core/core-legend-horizontal-alignment.page.tsx b/pages/03-core/core-legend-horizontal-alignment.page.tsx
@@ -5,10 +5,10 @@ import ColumnLayout from "@cloudscape-design/components/column-layout";
 import SpaceBetween from "@cloudscape-design/components/space-between";
 
 import { CoreChartProps } from "../../lib/components/core/interfaces";
-import omit from "../../lib/components/internal/utils/omit";
 import CoreChart from "../../lib/components/internal-do-not-use/core-chart";
 import { PageSettingsForm, useChartSettings } from "../common/page-settings";
 import { Page } from "../common/templates";
+import omit from "../utils/omit";
 import pseudoRandom from "../utils/pseudo-random";
 
 function randomInt(min: number, max: number) {
diff --git a/pages/03-core/core-legend.page.tsx b/pages/03-core/core-legend.page.tsx
@@ -11,12 +11,12 @@ import { CoreChartProps } from "../../lib/components/core/interfaces";
 import { colors } from "../../lib/components/internal/chart-styles";
 import { LegendItem } from "../../lib/components/internal/components/interfaces";
 import { ChartSeriesMarker } from "../../lib/components/internal/components/series-marker";
-import omit from "../../lib/components/internal/utils/omit";
 import CoreChart from "../../lib/components/internal-do-not-use/core-chart";
 import { CoreLegend } from "../../lib/components/internal-do-not-use/core-legend";
 import { dateFormatter } from "../common/formatters";
 import { PageSettingsForm, useChartSettings } from "../common/page-settings";
 import { Page } from "../common/templates";
+import omit from "../utils/omit";
 import pseudoRandom from "../utils/pseudo-random";
 
 function randomInt(min: number, max: number) {
diff --git a/pages/03-core/dynamic-chart-type.page.tsx b/pages/03-core/dynamic-chart-type.page.tsx
@@ -7,11 +7,11 @@ import Highcharts from "highcharts";
 import SpaceBetween from "@cloudscape-design/components/space-between";
 import Toggle from "@cloudscape-design/components/toggle";
 
-import omit from "../../lib/components/internal/utils/omit";
 import CoreChart, { CoreChartProps } from "../../lib/components/internal-do-not-use/core-chart";
 import { dateFormatter } from "../common/formatters";
 import { useChartSettings } from "../common/page-settings";
 import { Page } from "../common/templates";
+import omit from "../utils/omit";
 import pseudoRandom from "../utils/pseudo-random";
 
 function randomInt(min: number, max: number) {
diff --git a/pages/03-core/events-sync-demo.page.tsx b/pages/03-core/events-sync-demo.page.tsx
@@ -13,13 +13,13 @@ import {
 
 import { LegendItem } from "../../lib/components/internal/components/interfaces";
 import { ChartSeriesMarker } from "../../lib/components/internal/components/series-marker";
-import omit from "../../lib/components/internal/utils/omit";
 import CoreChart from "../../lib/components/internal-do-not-use/core-chart";
 import { CoreLegend } from "../../lib/components/internal-do-not-use/core-legend";
 import { CoreChartProps } from "../../src/core/interfaces";
 import { dateFormatter } from "../common/formatters";
 import { useChartSettings } from "../common/page-settings";
 import { Page } from "../common/templates";
+import omit from "../utils/omit";
 import pseudoRandom from "../utils/pseudo-random";
 
 function randomInt(min: number, max: number) {
diff --git a/pages/03-core/in-iframe.page.tsx b/pages/03-core/in-iframe.page.tsx
@@ -3,11 +3,11 @@
 
 import ColumnLayout from "@cloudscape-design/components/column-layout";
 
-import omit from "../../lib/components/internal/utils/omit";
 import CoreChart from "../../lib/components/internal-do-not-use/core-chart";
 import { dateFormatter } from "../common/formatters";
 import { useChartSettings } from "../common/page-settings";
 import { Page } from "../common/templates";
+import omit from "../utils/omit";
 
 export default function () {
   const { chartProps } = useChartSettings();
diff --git a/pages/03-core/no-data-states.page.tsx b/pages/03-core/no-data-states.page.tsx
@@ -5,10 +5,10 @@ import Highcharts from "highcharts";
 
 import Box from "@cloudscape-design/components/box";
 
-import omit from "../../lib/components/internal/utils/omit";
 import CoreChart from "../../lib/components/internal-do-not-use/core-chart";
 import { PageSettingsForm, useChartSettings } from "../common/page-settings";
 import { FramedDemo, Page, PageSection } from "../common/templates";
+import omit from "../utils/omit";
 
 export default function () {
   const { chartProps } = useChartSettings();
diff --git a/pages/03-core/simple-zooming.page.tsx b/pages/03-core/simple-zooming.page.tsx
@@ -11,11 +11,11 @@ import SpaceBetween from "@cloudscape-design/components/space-between";
 import { colorChartsBlue1400, colorChartsLineTick } from "@cloudscape-design/design-tokens";
 
 import { CoreChartProps } from "../../lib/components/core/interfaces";
-import omit from "../../lib/components/internal/utils/omit";
 import CoreChart from "../../lib/components/internal-do-not-use/core-chart";
 import { dateFormatter } from "../common/formatters";
 import { PageSettings, PageSettingsForm, useChartSettings } from "../common/page-settings";
 import { Page } from "../common/templates";
+import omit from "../utils/omit";
 import pseudoRandom from "../utils/pseudo-random";
 
 interface ThisPageSettings extends PageSettings {
@@ -134,7 +134,7 @@ function Charts() {
     settings: { keepZoomingFrame = true },
     chartProps,
   } = useChartSettings<ThisPageSettings>({ more: true });
-  const commonProps = omit(chartProps.cartesian, ["ref"]);
+  const commonProps = omit(chartProps.cartesian, "ref");
   const scatterChartRef = useRef<CoreChartProps.ChartAPI>(null) as React.MutableRefObject<CoreChartProps.ChartAPI>;
   const getScatterChart = () => scatterChartRef.current!;
   const navigatorChartRef = useRef<CoreChartProps.ChartAPI>(null) as React.MutableRefObject<CoreChartProps.ChartAPI>;
diff --git a/pages/03-core/solidgauge.page.tsx b/pages/03-core/solidgauge.page.tsx
@@ -1,10 +1,10 @@
 // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
 
-import omit from "../../lib/components/internal/utils/omit";
 import CoreChart from "../../lib/components/internal-do-not-use/core-chart";
 import { PageSettingsForm, useChartSettings } from "../common/page-settings";
 import { Page } from "../common/templates";
+import omit from "../utils/omit";
 import pseudoRandom from "../utils/pseudo-random";
 
 function randomInt(min: number, max: number) {
diff --git a/pages/06-visual-tests/cartesian-tooltip.page.tsx b/pages/06-visual-tests/cartesian-tooltip.page.tsx
@@ -3,11 +3,11 @@
 
 import Button from "@cloudscape-design/components/button";
 
-import omit from "../../lib/components/internal/utils/omit";
 import CoreChart from "../../lib/components/internal-do-not-use/core-chart";
 import { dateFormatter } from "../common/formatters";
 import { useChartSettings } from "../common/page-settings";
 import { Page } from "../common/templates";
+import omit from "../utils/omit";
 
 const baseline = [
   { x: 1600984800000, y: 58020 },
diff --git a/pages/06-visual-tests/in-iframe.page.tsx b/pages/06-visual-tests/in-iframe.page.tsx
@@ -1,10 +1,10 @@
 // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
 
-import omit from "../../lib/components/internal/utils/omit";
 import CoreChart from "../../lib/components/internal-do-not-use/core-chart";
 import { useChartSettings } from "../common/page-settings";
 import { Page } from "../common/templates";
+import omit from "../utils/omit";
 
 export default function () {
   const { chartProps } = useChartSettings();
diff --git a/pages/06-visual-tests/pie-tooltip.page.tsx b/pages/06-visual-tests/pie-tooltip.page.tsx
@@ -3,10 +3,10 @@
 
 import Button from "@cloudscape-design/components/button";
 
-import omit from "../../lib/components/internal/utils/omit";
 import CoreChart from "../../lib/components/internal-do-not-use/core-chart";
 import { useChartSettings } from "../common/page-settings";
 import { Page } from "../common/templates";
+import omit from "../utils/omit";
 
 const series: Highcharts.SeriesOptionsType[] = [
   {
diff --git a/pages/app/app-context.tsx b/pages/app/app-context.tsx
@@ -6,8 +6,6 @@ import { useSearchParams } from "react-router-dom";
 
 import { applyDensity, applyMode, Density, disableMotion, Mode } from "@cloudscape-design/global-styles";
 
-import mapValues from "../../lib/components/internal/utils/map-values";
-
 interface AppUrlParams {
   mode: Mode;
   density: Density;
@@ -40,16 +38,17 @@ const AppContext = createContext<AppContextType>(appContextDefaults);
 
 export default AppContext;
 
-function parseQuery(urlParams: URLSearchParams) {
-  const queryParams: Record<string, any> = { ...appContextDefaults.urlParams };
-  urlParams.forEach((value, key) => (queryParams[key] = value));
+function castToBoolean(s: string) {
+  if (s === "true" || s === "false") {
+    return s === "true";
+  }
+  return s;
+}
 
-  return mapValues(queryParams, (value) => {
-    if (value === "true" || value === "false") {
-      return value === "true";
-    }
-    return value;
-  });
+export function parseQuery(urlParams: URLSearchParams) {
+  const queryParams: Record<string, any> = { ...appContextDefaults };
+  urlParams.forEach((value, key) => (queryParams[key] = castToBoolean(value)));
+  return queryParams as AppUrlParams;
 }
 
 function formatQuery(params: AppUrlParams) {
diff --git a/pages/common/permutations.tsx b/pages/common/permutations.tsx
@@ -3,14 +3,12 @@
 
 import SpaceBetween from "@cloudscape-design/components/space-between";
 
-import flatten from "../../lib/components/internal/utils/flatten";
-
 export type ComponentPermutations<Props> = {
   [prop in keyof Props]: ReadonlyArray<Props[prop]>;
 };
 
 export function createPermutations<Props>(permutations: Array<ComponentPermutations<Props>>) {
-  return flatten(permutations.map((set) => doCreatePermutations(set)));
+  return permutations.map((set) => doCreatePermutations(set)).flat();
 }
 
 function doCreatePermutations<Props>(permutations: ComponentPermutations<Props>) {
diff --git a/pages/utils/omit.ts b/pages/utils/omit.ts
@@ -0,0 +1,18 @@
+// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+// SPDX-License-Identifier: Apache-2.0
+
+/**
+ * Creates an object composed of the own and inherited enumerable property paths
+ * of object that are not omitted
+ */
+export default function omit<T extends Record<string, unknown>, K extends keyof T>(object: T, keyToOmit: K) {
+  const result = {} as Partial<T>;
+
+  for (const key in object) {
+    if ((key as string as K) !== keyToOmit && Object.prototype.hasOwnProperty.call(object, key)) {
+      result[key] = object[key];
+    }
+  }
+
+  return result as Omit<T, K>;
+}
diff --git a/src/internal/sum.ts b/src/internal/sum.ts
diff --git a/src/internal/utils/flatten.ts b/src/internal/utils/flatten.ts
diff --git a/src/internal/utils/map-values.ts b/src/internal/utils/map-values.ts
diff --git a/src/internal/utils/omit.ts b/src/internal/utils/omit.ts
diff --git a/tsconfig.json b/tsconfig.json
@@ -18,6 +18,6 @@
     "strict": true,
     "tsBuildInfoFile": "./.cache/source.tsbuildinfo"
   },
-  "include": ["src", "types"],
+  "include": ["src", "types", "pages/utils/sum.ts", "pages/utils/map-values.ts", "pages/utils/flatten.ts", "pages/utils/omit.ts"],
   "exclude": ["**/__tests__/**", "src/test-utils/**"]
 }
