chore: Fix minimum-height and actions absolute positioning

Author: Ruben Carvalho

pages/code-view/with-actions-button.page.tsx

@@ -14,6 +14,12 @@ export default function CodeViewPage() {
           actions={<Button ariaLabel="Copy code" iconName="copy"></Button>}
           content={`Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop publishing software like Aldus PageMaker including versions of Lorem Ipsum.`}
         />
+        <CodeView
+          lineNumbers={true}
+          lineWrapping={true}
+          actions={<Button ariaLabel="Copy code" iconName="copy"></Button>}
+          content={`Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop publishing software like Aldus PageMaker including versions of Lorem Ipsum.`}
+        />
       </SpaceBetween>
     </ScreenshotArea>
   );

src/code-view/internal.tsx

@@ -58,39 +58,47 @@ export function InternalCodeView({
       aria-labelledby={ariaLabelledby}
       ref={__internalRootRef}
     >
-      <table className={clsx(styles["code-table"])}>
-        <colgroup>
-          <col style={{ width: 1 } /* shrink to fit content */} />
-          <col style={{ width: "auto" }} />
-        </colgroup>
-        <tbody>
-          {Children.map(code.props.children, (child, index) => {
-            return (
-              <tr key={index}>
-                {lineNumbers && (
-                  <td className={clsx(styles["line-number"], styles.unselectable)} aria-hidden={true}>
-                    <Box color="text-status-inactive" fontSize="body-m">
-                      {index + 1}
+      <div className={styles["scroll-container"]}>
+        <table
+          className={clsx(
+            styles["code-table"],
+            actions && styles["code-table-with-actions"],
+            lineWrapping && styles["code-table-with-line-wrapping"]
+          )}
+        >
+          <colgroup>
+            <col style={{ width: 1 } /* shrink to fit content */} />
+            <col style={{ width: "auto" }} />
+          </colgroup>
+          <tbody>
+            {Children.map(code.props.children, (child, index) => {
+              return (
+                <tr key={index}>
+                  {lineNumbers && (
+                    <td className={clsx(styles["line-number"], styles.unselectable)} aria-hidden={true}>
+                      <Box color="text-status-inactive" fontSize="body-m">
+                        {index + 1}
+                      </Box>
+                    </td>
+                  )}
+                  <td className={styles["code-line"]}>
+                    <Box color="text-status-inactive" variant="code" fontSize="body-m">
+                      <span
+                        className={clsx(
+                          code.props.className,
+                          lineWrapping ? styles["code-line-wrap"] : styles["code-line-nowrap"]
+                        )}
+                      >
+                        {child}
+                      </span>
                     </Box>
                   </td>
-                )}
-                <td className={styles["code-line"]}>
-                  <Box color="text-status-inactive" variant="code" fontSize="body-m">
-                    <span
-                      className={clsx(
-                        code.props.className,
-                        lineWrapping ? styles["code-line-wrap"] : styles["code-line-nowrap"]
-                      )}
-                    >
-                      {child}
-                    </span>
-                  </Box>
-                </td>
-              </tr>
-            );
-          })}
-        </tbody>
-      </table>
+                </tr>
+              );
+            })}
+          </tbody>
+        </table>
+      </div>
       {actions && <div className={styles.actions}>{actions}</div>}
     </div>
   );

src/code-view/styles.scss

@@ -10,6 +10,9 @@ $color-background-code-view-dark: #282c34;
     background-color: $color-background-code-view-dark;
   }
   background-color: $color-background-code-view-light;
+}
+
+.scroll-container {
   overflow-x: auto;
 }
 
@@ -23,6 +26,14 @@ $color-background-code-view-dark: #282c34;
   table-layout: auto;
   width: 100%;
   border-spacing: 0;
+
+  &-with-actions {
+    min-height: calc(2 * cs.$space-scaled-xs + cs.$space-scaled-xxl);
+  }
+}
+
+.code-table-with-actions.code-table-with-line-wrapping {
+  padding-inline-end: cs.$space-static-xxl;
 }
 
 .line-number {
@@ -59,7 +70,7 @@ $color-background-code-view-dark: #282c34;
 
 .actions {
   position: absolute;
-  inset-block-start: cs.$space-static-xs;
-  inset-inline-end: cs.$space-static-xs;
+  inset-block-start: cs.$space-scaled-xs;
+  inset-inline-end: cs.$space-scaled-xs;
   padding-inline-start: cs.$space-container-horizontal;
 }