chore: Add size-limit to the build process #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
=======================================
Coverage 72.72% 72.72%
=======================================
Files 9 9
Lines 66 66
Branches 17 17
=======================================
Hits 48 48
Misses 17 17
Partials 1 1 ☔ View full report in Codecov by Sentry. |
avinashbot
approved these changes
Mar 12, 2024
Member
avinashbot
left a comment
avinashbot
left a comment
There was a problem hiding this comment.
The limits are tight, but easy to update, so I don't mind too much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a build step to automatically catch unexpected bundle size changes, like on this one: #20 (comment)
If you make an intentional change (because of a new feature), it is fine to update the baseline, but the PR reviewer will be better aware what is happening
Related links, issue #, if available: n/a
How has this been tested?
PR build passes
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.