Skip to content

chore: Extract common visual theme code into helper function #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michaeldowseza merged 1 commit into from
Mar 18, 2025
Merged

chore: Extract common visual theme code into helper function #68

michaeldowseza merged 1 commit into from
Mar 18, 2025

Conversation

@michaeldowseza
Copy link
Member

@michaeldowseza michaeldowseza commented Mar 18, 2025 •
edited
Loading

Description

Ports over helper function from cloudscape-design/components#3355

Related links, issue #, if available: n/a

How has this been tested?

  • Copied over unit tests

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Mar 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.23%. Comparing base (b06e497) to head (27bb2c2).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   99.20%   99.23%   +0.02%     
==========================================
  Files          28       29       +1     
  Lines         251      260       +9     
  Branches       30       31       +1     
==========================================
+ Hits          249      258       +9     
  Misses          1        1              
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@michaeldowseza michaeldowseza marked this pull request as ready for review March 18, 2025 16:40
@michaeldowseza michaeldowseza requested a review from a team as a code owner March 18, 2025 16:40
@michaeldowseza michaeldowseza requested review from Al-Dani and removed request for a team March 18, 2025 16:40
@michaeldowseza michaeldowseza added this pull request to the merge queue Mar 18, 2025
Merged via the queue into main with commit 58f3e76 Mar 18, 2025
40 of 41 checks passed
@michaeldowseza michaeldowseza deleted the visual-theme branch March 18, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Al-Dani Al-Dani Al-Dani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaeldowseza @Al-Dani