Skip to content

Commit 7c5807a

Browse files
committed
refactor property based tests
1 parent 92f0795 commit 7c5807a

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

src/__tests__/use-collection-expadable-rows.test.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import { test, expect, describe } from 'vitest';
55
import { UseCollectionOptions } from '..';
66
import { Item } from './stubs';
7-
import { generateNestedItems, renderUseCollection } from './utils';
7+
import { generateRandomNestedItems, renderUseCollection } from './utils';
88

99
const getId = (item: Item) => item.id;
1010
const getParentId = (item: Item): null | string => {
@@ -279,8 +279,8 @@ describe('data grouping', () => {
279279
});
280280

281281
test('item counts sum up to total count', () => {
282-
for (let totalItems = 1; totalItems <= 25; totalItems += 5) {
283-
const items = generateNestedItems({ totalItems });
282+
for (let totalItems = 0; totalItems <= 25; totalItems += 1) {
283+
const items = generateRandomNestedItems({ totalItems });
284284
const { result } = renderUseCollection(items, {
285285
expandableRows: { getId, getParentId, dataGrouping: true },
286286
});
@@ -291,8 +291,8 @@ describe('data grouping', () => {
291291
});
292292

293293
test('total count equals items size when dataGrouping=undefined', () => {
294-
for (let totalItems = 1; totalItems <= 25; totalItems += 5) {
295-
const items = generateNestedItems({ totalItems });
294+
for (let totalItems = 0; totalItems <= 25; totalItems += 1) {
295+
const items = generateRandomNestedItems({ totalItems });
296296
const { result } = renderUseCollection(items, { expandableRows: { getId, getParentId } });
297297
expect(result.collectionProps.totalItemsCount).toBe(items.length);
298298
}

src/__tests__/utils.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@ export function renderUseCollection<T>(allItems: readonly T[], options: UseColle
2727
return current;
2828
}
2929

30-
export const generateNestedItems = ({ totalItems }: { totalItems: number }) => {
30+
// Generates random items tree to be used for property-based tests.
31+
export const generateRandomNestedItems = ({ totalItems }: { totalItems: number }) => {
3132
const items: Item[] = [];
3233
let nextIndex = 0;
3334
let level = 1;

0 commit comments

Comments
 (0)