Skip to content

Commit dc6d8c1

Browse files
fralongoFrancesco Longo
andauthored
fix: Self-referring aria-labelledby (#91)
Co-authored-by: Francesco Longo <flongo@amazon.de>
1 parent acc9a5f commit dc6d8c1

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

src/internal/analytics-metadata/__tests__/labels-utils.test.tsx

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,15 @@ describe('getLabelFromElement', () => {
8282
const target = container.querySelector('#target');
8383
expect(getLabelFromElement(target as HTMLElement)).toEqual('second content');
8484
});
85+
test('returns text content aria-labelledby refers to the element itself', () => {
86+
const { container } = render(
87+
<div id="target" aria-labelledby="target">
88+
content
89+
</div>
90+
);
91+
const target = container.querySelector('#target');
92+
expect(getLabelFromElement(target as HTMLElement)).toEqual('content');
93+
});
8594
test('returns empty string if aria-labelledby element does not exist', () => {
8695
const { container } = render(
8796
<div>

src/internal/analytics-metadata/labels-utils.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,9 @@ export const getLabelFromElement = (element: HTMLElement | null): string => {
6161
const ariaLabelledBy = element.getAttribute('aria-labelledby');
6262
if (ariaLabelledBy) {
6363
const elementWithLabel = document.querySelector(`[id="${ariaLabelledBy.split(' ')[0]}"]`);
64-
return getLabelFromElement(elementWithLabel as HTMLElement);
64+
if (elementWithLabel !== element) {
65+
return getLabelFromElement(elementWithLabel as HTMLElement);
66+
}
6567
}
6668

6769
return element.textContent ? element.textContent.trim() : '';

0 commit comments

Comments
 (0)