Skip to content

Commit 33bce10

Browse files
authored
chore: Make sure stylelint issues fail the build (#3640)
1 parent 0391953 commit 33bce10

File tree

9 files changed

+51
-47
lines changed

9 files changed

+51
-47
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"test:motion": "gulp test:motion",
1818
"lint": "npm-run-all --parallel lint:*",
1919
"lint:eslint": "eslint .",
20-
"lint:stylelint": "stylelint --ignore-path .gitignore --fix '{src,pages}/**/*.{css,scss}'",
20+
"lint:stylelint": "stylelint --ignore-path .gitignore '{src,pages}/**/*.{css,scss}'",
2121
"start": "npm-run-all --parallel start:watch start:dev",
2222
"start:watch": "gulp watch",
2323
"start:dev": "cross-env NODE_ENV=development webpack serve --config pages/webpack.config.cjs",

src/app-layout/visual-refresh/styles.scss

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@
33
SPDX-License-Identifier: Apache-2.0
44
*/
55

6-
@use './background.scss';
7-
@use './breadcrumbs.scss';
8-
@use './drawers.scss';
9-
@use './header.scss';
10-
@use './layout.scss';
11-
@use './main.scss';
12-
@use './mobile-toolbar.scss';
13-
@use './navigation.scss';
14-
@use './notifications.scss';
15-
@use './split-panel.scss';
16-
@use './tools.scss';
17-
@use './trigger-button.scss';
6+
@use './background';
7+
@use './breadcrumbs';
8+
@use './drawers';
9+
@use './header';
10+
@use './layout';
11+
@use './main';
12+
@use './mobile-toolbar';
13+
@use './navigation';
14+
@use './notifications';
15+
@use './split-panel';
16+
@use './tools';
17+
@use './trigger-button';

src/button/styles.scss

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,10 @@
9595
'vertical': awsui.$space-button-icon-focus-outline-gutter-vertical,
9696
'horizontal': awsui.$space-button-focus-outline-gutter,
9797
),
98-
$border-radius:
99-
var(#{custom-props.$styleFocusRingBorderRadius}, awsui.$border-radius-control-default-focus-ring),
98+
$border-radius: var(
99+
#{custom-props.$styleFocusRingBorderRadius},
100+
awsui.$border-radius-control-default-focus-ring
101+
),
100102
$box-shadow: var(#{custom-props.$styleFocusRingBoxShadow})
101103
);
102104
}

src/content-layout/styles.scss

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@
1212
#{custom-props.$contentLayoutMainGap}: 0px;
1313
display: grid;
1414
grid-template-columns: 0 0 1fr minmax(0, var(#{custom-props.$contentLayoutMaxContentWidth})) 1fr 0 0;
15-
grid-template-rows: var(#{custom-props.$contentLayoutMainGap}) min-content min-content auto awsui.$space-dark-header-overlap-distance 1fr;
15+
grid-template-rows:
16+
var(#{custom-props.$contentLayoutMainGap})
17+
min-content min-content auto awsui.$space-dark-header-overlap-distance 1fr;
1618
min-block-size: 100%;
1719

1820
@include styles.media-breakpoint-down(styles.$breakpoint-x-small) {
@@ -48,10 +50,8 @@
4850
&.default-padding {
4951
#{custom-props.$contentLayoutMainGap}: awsui.$space-scaled-m;
5052
grid-template-columns:
51-
var(#{custom-props.$togglesLeftWidth}, 0) var(#{custom-props.$contentLayoutDefaultHorizontalPadding}, 0) 1fr minmax(
52-
0,
53-
var(#{custom-props.$contentLayoutMaxContentWidth})
54-
)
53+
var(#{custom-props.$togglesLeftWidth}, 0) var(#{custom-props.$contentLayoutDefaultHorizontalPadding}, 0)
54+
1fr minmax(0, var(#{custom-props.$contentLayoutMaxContentWidth}))
5555
1fr var(#{custom-props.$contentLayoutDefaultHorizontalPadding}, 0) var(#{custom-props.$togglesRightWidth}, 0);
5656
}
5757

src/icon/styles.scss

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -29,25 +29,25 @@
2929
@include mixins.make-icon-variants;
3030

3131
&:is(
32-
.name-angle-left-double,
33-
.name-angle-left,
34-
.name-angle-right-double,
35-
.name-angle-right,
36-
.name-arrow-left,
37-
.name-arrow-right,
38-
.name-caret-left-filled,
39-
.name-caret-right-filled,
40-
.name-audio-full,
41-
.name-audio-half,
42-
.name-audio-off,
43-
.name-external,
44-
.name-redo,
45-
.name-resize-area,
46-
.name-send,
47-
.name-shrink,
48-
.name-undo,
49-
.name-view-vertical
50-
) {
32+
.name-angle-left-double,
33+
.name-angle-left,
34+
.name-angle-right-double,
35+
.name-angle-right,
36+
.name-arrow-left,
37+
.name-arrow-right,
38+
.name-caret-left-filled,
39+
.name-caret-right-filled,
40+
.name-audio-full,
41+
.name-audio-half,
42+
.name-audio-off,
43+
.name-external,
44+
.name-redo,
45+
.name-resize-area,
46+
.name-send,
47+
.name-shrink,
48+
.name-undo,
49+
.name-view-vertical
50+
) {
5151
@include styles.with-direction('rtl') {
5252
transform: scaleX(-1);
5353
}

src/input/styles.scss

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,8 @@
8484
@include styles.form-invalid-control();
8585
&.input-has-icon-left {
8686
padding-inline-start: calc(
87-
#{styles.$control-icon-horizontal-padding} - (#{styles.$invalid-control-left-border} - #{awsui.$border-width-field})
87+
#{styles.$control-icon-horizontal-padding} -
88+
(#{styles.$invalid-control-left-border} - #{awsui.$border-width-field})
8889
);
8990
}
9091
}
@@ -93,7 +94,8 @@
9394
@include styles.form-warning-control();
9495
&.input-has-icon-left {
9596
padding-inline-start: calc(
96-
#{styles.$control-icon-horizontal-padding} - (#{styles.$invalid-control-left-border} - #{awsui.$border-width-field})
97+
#{styles.$control-icon-horizontal-padding} -
98+
(#{styles.$invalid-control-left-border} - #{awsui.$border-width-field})
9799
);
98100
}
99101
}

src/internal/base-component/styles.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
SPDX-License-Identifier: Apache-2.0
99
*/
1010
@use 'awsui:globals';
11-
@use '../styles/global.scss';
11+
@use '../styles/global';
1212
@use '../generated/custom-css-properties' as custom-styles;
1313

1414
:root {

src/link/constants.scss

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,7 @@ $link-variants: (
9898
),
9999
// Need separate variant used for backwards compatible styles in classic
100100
// (vr - button style, classic - underlined link style),
101-
'recovery':
102-
(
101+
'recovery': (
103102
'text-color-default': awsui.$color-text-link-default,
104103
'text-color-hover': awsui.$color-text-link-hover,
105104
'text-color-active': awsui.$color-text-link-hover,
@@ -113,8 +112,7 @@ $link-variants: (
113112

114113
$link-styles: (
115114
// A link without an href to be styled like a button
116-
'button':
117-
(
115+
'button': (
118116
'text-color-default': awsui.$color-text-link-button-normal-default,
119117
'text-color-hover': awsui.$color-text-link-button-normal-hover,
120118
'text-color-active': awsui.$color-text-link-button-normal-active,

src/property-filter/styles.scss

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,9 @@ $operator-field-width: 120px;
151151

152152
display: grid;
153153
gap: awsui.$space-s;
154-
grid-template-columns: minmax(min-content, 2fr) minmax(min-content, $operator-field-width) minmax(min-content, 3fr) min-content;
154+
grid-template-columns:
155+
minmax(min-content, 2fr) minmax(min-content, $operator-field-width) minmax(min-content, 3fr)
156+
min-content;
155157

156158
&-group {
157159
display: contents;

0 commit comments

Comments
 (0)