fix: Remove deprecation annotation on side navigation externalIconAriaLabel link property (#4392)

Author: SpyZzey

src/__tests__/snapshot-tests/__snapshots__/documenter.test.ts.snap

@@ -24768,7 +24768,6 @@ Links are rendered as \`<a>\` tags.
      The anchor also has the attributes \`target="_blank"\` and \`rel="noopener"\`.
      Additionally, the \`activeHref\` property won't be modified when a user chooses the link.
 - \`externalIconAriaLabel\` (string) - Adds an aria-label to the external icon.
-Note: Deprecated, use i18nStrings.externalIconAriaLabel instead.
 - \`info\` (ReactNode) - Enables you to display content next to the link. Although it is technically possible to insert any content,
     our UX guidelines allow only to add a Badge and/or a "New" label.
 

src/side-navigation/interfaces.tsx

@@ -50,7 +50,6 @@ export interface SideNavigationProps extends BaseComponentProps {
    *      The anchor also has the attributes `target="_blank"` and `rel="noopener"`.
    *      Additionally, the `activeHref` property won't be modified when a user chooses the link.
    * - `externalIconAriaLabel` (string) - Adds an aria-label to the external icon.
-   * Note: Deprecated, use i18nStrings.externalIconAriaLabel instead.
    * - `info` (ReactNode) - Enables you to display content next to the link. Although it is technically possible to insert any content,
    *     our UX guidelines allow only to add a Badge and/or a "New" label.
    *
@@ -147,9 +146,6 @@ export namespace SideNavigationProps {
     text: string;
     href: string;
     external?: boolean;
-    /**
-     * @deprecated Use i18nStrings.externalIconAriaLabel instead.
-     */
     externalIconAriaLabel?: string;
     info?: React.ReactNode;
   }