applies review suggestions

Author: pan-kot

pages/error-boundary/error-boundary-fallbacks.page.tsx

@@ -24,7 +24,7 @@ console.error = () => {};
 
 export default function () {
   return (
-    <SimplePage title="Error boundary fallbacks" i18n={{}}>
+    <SimplePage title="Error boundary fallbacks" i18n={{}} screenshotArea={{}}>
       <SpaceBetween size="l">
         <Section title="Default">
           <Example code="{}" />

src/__tests__/snapshot-tests/__snapshots__/design-tokens.test.ts.snap

@@ -1,4 +1,4 @@
-// Jest Snapshot v1, https://goo.gl/fbAQLP
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
 
 exports[`Design tokens artifacts Design tokens JSON for classic matches the snapshot: classic 1`] = `
 {

src/__tests__/snapshot-tests/__snapshots__/documenter.test.ts.snap

@@ -11492,7 +11492,7 @@ case, any error originating from the error boundary content will be captured by
   ],
   "regions": [
     {
-      "description": "Content, rendered when no error is captured.",
+      "description": "Content rendered when no error is captured.",
       "isDefault": true,
       "name": "children",
     },

src/container/internal.tsx

@@ -156,6 +156,7 @@ export default function InternalContainer({
         key={__contentKey}
         className={clsx(styles['content-wrapper'], fitHeight && styles['content-wrapper-fit-height'])}
       >
+        {/* We use a wrapper around the boundary to preserve container's paddings. */}
         <BuiltInErrorBoundary wrapper={content => <InternalBox padding="m">{content}</InternalBox>}>
           {header && (
             <ContainerHeaderContextProvider>
@@ -197,6 +198,9 @@ export default function InternalContainer({
               })}
               style={getContentStyles(style)}
             >
+              {/* We use a wrapper around the boundary to preserve paddings in case they were disabled by the consumer.
+              That is needed because the consumer-defined paddings that normally come with the content can no longer
+              apply since the content failed to render. */}
               <BuiltInErrorBoundary
                 wrapper={content => (
                   <InternalBox padding={disableContentPaddings ? 'm' : undefined}>{content}</InternalBox>

src/error-boundary/interfaces.ts

@@ -49,7 +49,7 @@ export interface ErrorBoundaryProps {
   i18nStrings?: ErrorBoundaryProps.I18nStrings;
 
   /**
-   * Content, rendered when no error is captured.
+   * Content rendered when no error is captured.
    */
   children: React.ReactNode;
 }

src/error-boundary/internal.tsx

@@ -112,7 +112,7 @@ class ErrorBoundaryImpl extends Component<ErrorBoundaryImplProps, ErrorBoundaryS
   }
 
   componentDidCatch(error: Error, errorInfo: React.ErrorInfo): void {
-    this.props.onError?.({ error, errorInfo, errorBoundaryId: this.props.errorBoundaryId });
+    this.props.onError({ error, errorInfo, errorBoundaryId: this.props.errorBoundaryId });
   }
 
   render() {