Skip to content

Commit 95c1247

Browse files
authored
fix: Add I18nProvider support for code editor theme filtering input (#3265)
1 parent b29b255 commit 95c1247

File tree

17 files changed

+43
-2
lines changed

17 files changed

+43
-2
lines changed

src/code-editor/__tests__/code-editor.test.tsx

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -661,6 +661,8 @@ describe('Code editor component', () => {
661661
'i18nStrings.preferencesModalTheme': 'Custom theme',
662662
'i18nStrings.preferencesModalLightThemes': 'Custom light themes',
663663
'i18nStrings.preferencesModalDarkThemes': 'Custom dark themes',
664+
'i18nStrings.preferencesModalThemeFilteringAriaLabel': 'Custom theme filter',
665+
'i18nStrings.preferencesModalThemeFilteringPlaceholder': 'Custom theme filter placeholder',
664666
},
665667
}}
666668
>
@@ -680,6 +682,9 @@ describe('Code editor component', () => {
680682
expect(modal.findContent()!.findCheckbox()!.findLabel().getElement()).toHaveTextContent('Custom wrap lines');
681683
expect(modal.findContent()!.findFormField()!.findLabel()!.getElement()).toHaveTextContent('Custom theme');
682684
modal.findContent()!.findSelect()!.openDropdown();
685+
const filteringInput = modal.findContent()!.findSelect()!.findFilteringInput()!.findNativeInput().getElement();
686+
expect(filteringInput).toHaveAccessibleName('Custom theme filter');
687+
expect(filteringInput).toHaveAttribute('placeholder', 'Custom theme filter placeholder');
683688
expect(modal.findContent()!.findSelect()!.findDropdown().find('li:nth-child(1)')!.getElement()).toHaveTextContent(
684689
'Custom light themes'
685690
);

src/code-editor/index.tsx

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -291,9 +291,15 @@ const CodeEditor = forwardRef((props: CodeEditorProps, ref: React.Ref<CodeEditor
291291
theme: i18n('i18nStrings.preferencesModalTheme', i18nStrings?.preferencesModalTheme),
292292
lightThemes: i18n('i18nStrings.preferencesModalLightThemes', i18nStrings?.preferencesModalLightThemes),
293293
darkThemes: i18n('i18nStrings.preferencesModalDarkThemes', i18nStrings?.preferencesModalDarkThemes),
294-
themeFilteringAriaLabel: i18nStrings?.preferencesModalThemeFilteringAriaLabel,
294+
themeFilteringAriaLabel: i18n(
295+
'i18nStrings.preferencesModalThemeFilteringAriaLabel',
296+
i18nStrings?.preferencesModalThemeFilteringAriaLabel
297+
),
298+
themeFilteringPlaceholder: i18n(
299+
'i18nStrings.preferencesModalThemeFilteringPlaceholder',
300+
i18nStrings?.preferencesModalThemeFilteringPlaceholder
301+
),
295302
themeFilteringClearAriaLabel: i18nStrings?.preferencesModalThemeFilteringClearAriaLabel,
296-
themeFilteringPlaceholder: i18nStrings?.preferencesModalThemeFilteringPlaceholder,
297303
}}
298304
/>
299305
)}

src/i18n/messages-types.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,8 @@ export interface I18nFormatArgTypes {
104104
"i18nStrings.preferencesModalConfirm": never;
105105
"i18nStrings.preferencesModalWrapLines": never;
106106
"i18nStrings.preferencesModalTheme": never;
107+
"i18nStrings.preferencesModalThemeFilteringAriaLabel": never;
108+
"i18nStrings.preferencesModalThemeFilteringPlaceholder": never;
107109
"i18nStrings.preferencesModalLightThemes": never;
108110
"i18nStrings.preferencesModalDarkThemes": never;
109111
"i18nStrings.cursorPositionAriaLabel": {

src/i18n/messages/all.ar.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,8 @@
8484
"i18nStrings.preferencesModalConfirm": "تأكيد",
8585
"i18nStrings.preferencesModalWrapLines": "ترحيل الكلمات من نهاية السطر",
8686
"i18nStrings.preferencesModalTheme": "الشكل",
87+
"i18nStrings.preferencesModalThemeFilteringAriaLabel": "تصفية الموضوعات",
88+
"i18nStrings.preferencesModalThemeFilteringPlaceholder": "تصفية الموضوعات",
8789
"i18nStrings.preferencesModalLightThemes": "الأشكال فاتحة اللون",
8890
"i18nStrings.preferencesModalDarkThemes": "الأشكال قاتمة اللون",
8991
"i18nStrings.cursorPositionAriaLabel": "المؤشر على السطر رقم {row}"

src/i18n/messages/all.de.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,8 @@
8484
"i18nStrings.preferencesModalConfirm": "Bestätigen",
8585
"i18nStrings.preferencesModalWrapLines": "Zeilenumbruch",
8686
"i18nStrings.preferencesModalTheme": "Themen",
87+
"i18nStrings.preferencesModalThemeFilteringAriaLabel": "Themen filtern",
88+
"i18nStrings.preferencesModalThemeFilteringPlaceholder": "Themen filtern",
8789
"i18nStrings.preferencesModalLightThemes": "Hellere Themen",
8890
"i18nStrings.preferencesModalDarkThemes": "Dunkles Design",
8991
"i18nStrings.cursorPositionAriaLabel": "Cursor in Zeile {row}"

src/i18n/messages/all.en-GB.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,8 @@
8484
"i18nStrings.preferencesModalConfirm": "Confirm",
8585
"i18nStrings.preferencesModalWrapLines": "Wrap lines",
8686
"i18nStrings.preferencesModalTheme": "Theme",
87+
"i18nStrings.preferencesModalThemeFilteringAriaLabel": "Filter themes",
88+
"i18nStrings.preferencesModalThemeFilteringPlaceholder": "Filter themes",
8789
"i18nStrings.preferencesModalLightThemes": "Light themes",
8890
"i18nStrings.preferencesModalDarkThemes": "Dark themes",
8991
"i18nStrings.cursorPositionAriaLabel": "Cursor on row {row}"

src/i18n/messages/all.en.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,8 @@
8484
"i18nStrings.preferencesModalConfirm": "Confirm",
8585
"i18nStrings.preferencesModalWrapLines": "Wrap lines",
8686
"i18nStrings.preferencesModalTheme": "Theme",
87+
"i18nStrings.preferencesModalThemeFilteringAriaLabel": "Filter themes",
88+
"i18nStrings.preferencesModalThemeFilteringPlaceholder": "Filter themes",
8789
"i18nStrings.preferencesModalLightThemes": "Light themes",
8890
"i18nStrings.preferencesModalDarkThemes": "Dark themes",
8991
"i18nStrings.cursorPositionAriaLabel": "Cursor on row {row}"

src/i18n/messages/all.es.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,8 @@
8484
"i18nStrings.preferencesModalConfirm": "Confirmar",
8585
"i18nStrings.preferencesModalWrapLines": "Ajustar líneas",
8686
"i18nStrings.preferencesModalTheme": "Tema",
87+
"i18nStrings.preferencesModalThemeFilteringAriaLabel": "Filtrar temas",
88+
"i18nStrings.preferencesModalThemeFilteringPlaceholder": "Filtrar temas",
8789
"i18nStrings.preferencesModalLightThemes": "Temas claros",
8890
"i18nStrings.preferencesModalDarkThemes": "Temas oscuros",
8991
"i18nStrings.cursorPositionAriaLabel": "Cursor en fila {row}"

src/i18n/messages/all.fr.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,8 @@
8484
"i18nStrings.preferencesModalConfirm": "Confirmer",
8585
"i18nStrings.preferencesModalWrapLines": "Retour à la ligne",
8686
"i18nStrings.preferencesModalTheme": "Thème",
87+
"i18nStrings.preferencesModalThemeFilteringAriaLabel": "Filtrer les thèmes",
88+
"i18nStrings.preferencesModalThemeFilteringPlaceholder": "Filtrer les thèmes",
8789
"i18nStrings.preferencesModalLightThemes": "Thèmes clairs",
8890
"i18nStrings.preferencesModalDarkThemes": "Thèmes sombres",
8991
"i18nStrings.cursorPositionAriaLabel": "Curseur sur la ligne {row}"

src/i18n/messages/all.id.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,8 @@
8484
"i18nStrings.preferencesModalConfirm": "Konfirmasikan",
8585
"i18nStrings.preferencesModalWrapLines": "Bungkus baris",
8686
"i18nStrings.preferencesModalTheme": "Tema",
87+
"i18nStrings.preferencesModalThemeFilteringAriaLabel": "Filter tema",
88+
"i18nStrings.preferencesModalThemeFilteringPlaceholder": "Filter tema",
8789
"i18nStrings.preferencesModalLightThemes": "Tema terang",
8890
"i18nStrings.preferencesModalDarkThemes": "Tema gelap",
8991
"i18nStrings.cursorPositionAriaLabel": "Kursor pada baris {row}"

0 commit comments

Comments
 (0)