rename min height to min visible block size

Author: pan-kot

src/internal/components/chart-popover/index.tsx

@@ -129,7 +129,7 @@ function ChartPopover(
         trackRef={trackRef}
         getTrack={getTrack}
         trackKey={trackKey}
-        minHeight={minHeight}
+        minVisibleBlockSize={minHeight}
         arrow={position => (
           <div className={clsx(popoverStyles.arrow, popoverStyles[`arrow-position-${position}`])}>
             <div className={popoverStyles['arrow-outer']} />

src/popover/__tests__/positions.test.ts

@@ -45,7 +45,7 @@ describe('calculatePosition', () => {
         trigger,
         arrow,
         body: { inlineSize: 250, blockSize: 1000 },
-        minHeight: 250,
+        minVisibleBlockSize: 250,
         container: viewport,
         viewport,
       });

src/popover/container.tsx

@@ -26,7 +26,7 @@ interface PopoverContainerProps {
     </>)
   */
   trackKey?: string | number;
-  minHeight?: number;
+  minVisibleBlockSize?: number;
   position: PopoverProps.Position;
   zIndex?: React.CSSProperties['zIndex'];
   arrow: (position: InternalPosition | null) => React.ReactNode;
@@ -52,7 +52,7 @@ export default function PopoverContainer({
   trackRef,
   getTrack: externalGetTrack,
   trackKey,
-  minHeight,
+  minVisibleBlockSize,
   arrow,
   children,
   zIndex,
@@ -98,7 +98,7 @@ export default function PopoverContainer({
       renderWithPortal,
       keepPosition,
       hideOnOverscroll,
-      minHeight,
+      minVisibleBlockSize,
     });
 
   // Recalculate position when properties change.

src/popover/use-popover-position.ts

@@ -27,7 +27,7 @@ export default function usePopoverPosition({
   renderWithPortal,
   keepPosition,
   hideOnOverscroll,
-  minHeight,
+  minVisibleBlockSize,
 }: {
   popoverRef: React.RefObject<HTMLDivElement | null>;
   bodyRef: React.RefObject<HTMLDivElement | null>;
@@ -40,7 +40,7 @@ export default function usePopoverPosition({
   renderWithPortal?: boolean;
   keepPosition?: boolean;
   hideOnOverscroll?: boolean;
-  minHeight?: number;
+  minVisibleBlockSize?: number;
 }) {
   const previousInternalPositionRef = useRef<InternalPosition | null>(null);
   const [popoverStyle, setPopoverStyle] = useState<Partial<Offset>>({});
@@ -132,7 +132,7 @@ export default function usePopoverPosition({
         viewport: viewportRect,
         renderWithPortal,
         allowVerticalOverflow,
-        minHeight,
+        minVisibleBlockSize,
       });
 
       // Get the position of the popover relative to the containing block.
@@ -215,7 +215,7 @@ export default function usePopoverPosition({
       allowVerticalOverflow,
       allowScrollToFit,
       hideOnOverscroll,
-      minHeight,
+      minVisibleBlockSize,
     ]
   );
   return { updatePositionHandler, popoverStyle, internalPosition, positionHandlerRef, isOverscrolling };

src/popover/utils/positions.ts

@@ -239,7 +239,7 @@ export function calculatePosition({
   // the popover is only bound by the viewport if it is rendered in a portal
   renderWithPortal,
   allowVerticalOverflow,
-  minHeight,
+  minVisibleBlockSize,
 }: {
   preferredPosition: PopoverProps.Position;
   fixedInternalPosition?: InternalPosition;
@@ -251,7 +251,7 @@ export function calculatePosition({
   // the popover is only bound by the viewport if it is rendered in a portal
   renderWithPortal?: boolean;
   allowVerticalOverflow?: boolean;
-  minHeight?: number;
+  minVisibleBlockSize?: number;
 }): CalculatedPosition {
   let bestOption: CandidatePosition | null = null;
 
@@ -267,12 +267,12 @@ export function calculatePosition({
       ? getIntersection([rect, viewport])
       : getIntersection([rect, viewport, container]);
 
-    // When min height is set, the popover is considered fitting the container if the available space
-    // is the same or larger than min height, even if it means the scrollbar is needed.
+    // When min visible block size is set, the popover is considered fitting the container if the available space
+    // is the same or larger than min allowed, even if it means the scrollbar is needed.
     const fitsBlockSize =
-      minHeight === undefined
+      minVisibleBlockSize === undefined
         ? visibleArea && visibleArea.blockSize === body.blockSize
-        : visibleArea && visibleArea.blockSize >= Math.min(body.blockSize, minHeight);
+        : visibleArea && visibleArea.blockSize >= Math.min(body.blockSize, minVisibleBlockSize);
     const fitsInlineSize = visibleArea && visibleArea.inlineSize === body.inlineSize;
 
     if (fitsBlockSize && fitsInlineSize) {