refactor: apply ES2019 optional catch binding and array methods (#4036)

Author: TrevorBurnham

src/collection-preferences/visible-content.tsx

@@ -33,10 +33,7 @@ export default function VisibleContentPreference({
 }: VisibleContentPreferenceProps) {
   const idPrefix = useUniqueId('visible-content');
 
-  const flatOptionsIds = options.reduce<string[]>(
-    (ids, group) => [...ids, ...group.options.reduce<string[]>((groupIds, option) => [...groupIds, option.id], [])],
-    []
-  );
+  const flatOptionsIds = options.flatMap(group => group.options.map(option => option.id));
 
   const onToggle = (id: string) => {
     if (!isVisible(id, value)) {

src/internal/plugins/api.ts

@@ -51,10 +51,7 @@ function findUpApi(currentWindow: WindowWithApi): AwsuiApi | undefined {
     }
 
     return findUpApi(currentWindow.parent as WindowWithApi);
-
-    // Consumers in the past have not always been able to support not specifiying the value so we keep and ignore
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  } catch (ex) {
+  } catch {
     // Most likely a cross-origin access error
     return undefined;
   }

src/internal/utils/check-safe-url.ts

@@ -15,10 +15,7 @@ export function checkSafeUrl(component: string, url: string | undefined | null):
   let parsedUrl: URL;
   try {
     parsedUrl = new URL(url);
-
-    // Consumers in the past have not always been able to support not specifiying the value so we keep and ignore
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  } catch (e) {
+  } catch {
     // If the URL cannot be parsed by the browser, it likely does not pose a security risk.
     return;
   }

src/mixed-line-bar-chart/make-scaled-series.ts

@@ -118,18 +118,9 @@ function getAllX<T>(series: ReadonlyArray<InternalChartSeries<T>>) {
         break;
     }
   }
-  const allDataX: T[] = [];
-  addDataXSet.forEach(x => allDataX.push(x));
-
-  return allDataX;
+  return Array.from(addDataXSet);
 }
 
 function flatten<T>(arrays: T[][]): T[] {
-  const merged: T[] = [];
-  for (const array of arrays) {
-    for (const item of array) {
-      merged.push(item);
-    }
-  }
-  return merged;
+  return arrays.flat();
 }

src/table/body-cell/inline-editor.tsx

@@ -63,10 +63,7 @@ export function InlineEditor<ItemType>({
       await submitEdit(item, column, currentEditValue);
       setCurrentEditLoading(false);
       finishEdit();
-
-      // Consumers in the past have not always been able to support not specifiying the value so we keep and ignore
-      // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    } catch (e) {
+    } catch {
       setCurrentEditLoading(false);
       focusLockRef.current?.focusFirst();
     }