Skip to content

Commit bf310ca

Browse files
committed
fix: Test for select update
1 parent 4e86c20 commit bf310ca

File tree

4 files changed

+2
-5
lines changed

4 files changed

+2
-5
lines changed

src/select/__tests__/disabled.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ describe.each([false, true])('expandToViewport=%s', expandToViewport => {
175175
wrapper.findTrigger().keydown(KeyCode.down);
176176
const dropdown = wrapper.findDropdown({ expandToViewport });
177177
expect(dropdown.findOption(1)!.findDisabledReason()!.getElement()).toHaveTextContent('disabled reason');
178-
window.dispatchEvent(new Event('scroll'));
178+
fireEvent.scroll(dropdown.findOptionsContainer()!.getElement());
179179
await waitFor(() => {
180180
expect(dropdown.findOption(1)!.findDisabledReason()).toBe(null);
181181
});

src/select/parts/item.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,6 @@ const Item = (
121121
getTrack={() => internalRef.current}
122122
content={disabledReason!}
123123
position="right"
124-
__dismissOnScroll={true}
125124
__onDismissOnScroll={() => setCanShowTooltip(false)}
126125
onEscape={() => setCanShowTooltip(false)}
127126
/>

src/select/parts/multiselect-item.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,6 @@ const MultiSelectItem = (
112112
getTrack={() => internalRef.current}
113113
content={disabledReason!}
114114
position="right"
115-
__dismissOnScroll={true}
116115
onEscape={() => setCanShowTooltip(false)}
117116
/>
118117
)}

src/tooltip/internal.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ export default function InternalTooltip({
2323
getTrack,
2424
trackKey,
2525
position = 'top',
26-
__dismissOnScroll,
2726
__onDismissOnScroll,
2827
onEscape,
2928
__internalRootRef,
@@ -87,7 +86,7 @@ export default function InternalTooltip({
8786
position={position}
8887
zIndex={7000}
8988
arrow={position => <PopoverArrow position={position} />}
90-
hideOnOverscroll={__dismissOnScroll}
89+
hideOnOverscroll={true}
9190
onOverscroll={handleDismissOnScroll}
9291
>
9392
<PopoverBody dismissButton={false} dismissAriaLabel={undefined} onDismiss={undefined} header={undefined}>

0 commit comments

Comments
 (0)