fix: Analytics label for icon buttons with children (#3559)

Co-authored-by: Francesco Longo <[email protected]>

Author: fralongo

src/button/__tests__/analytics-metadata.test.tsx

@@ -75,6 +75,15 @@ describe('Button renders correct analytics metadata', () => {
     validateComponentNameAndLabels(wrapper.getElement(), labels);
     expect(getGeneratedAnalyticsMetadata(wrapper.getElement())).toEqual(getMetadata('button text aria', 'inline-icon'));
   });
+  test('when it has icon variant and children', () => {
+    const wrapper = renderButton({
+      ariaLabel: 'button text aria',
+      variant: 'inline-icon',
+      children: 'invisible but there',
+    });
+    validateComponentNameAndLabels(wrapper.getElement(), labels);
+    expect(getGeneratedAnalyticsMetadata(wrapper.getElement())).toEqual(getMetadata('button text aria', 'inline-icon'));
+  });
 });
 describe('Internal Button', () => {
   test('does not render "component" metadata', () => {

src/button/internal.tsx

@@ -222,7 +222,7 @@ export const InternalButton = React.forwardRef(
       onClick: handleClick,
       [DATA_ATTR_FUNNEL_VALUE]: uniqueId,
       ...getAnalyticsMetadataAttribute(analyticsMetadata),
-      ...getAnalyticsLabelAttribute(children ? `.${analyticsSelectors.label}` : ''),
+      ...getAnalyticsLabelAttribute(shouldHaveContent ? `.${analyticsSelectors.label}` : ''),
     } as const;
 
     const iconProps: ButtonIconProps = {