Skip to content

Commit d6809af

Browse files
committed
fix: analytics-metadata.test.tsx
1 parent f628f82 commit d6809af

File tree

2 files changed

+22
-6
lines changed

2 files changed

+22
-6
lines changed

src/app-layout-toolbar/__tests__/analytics-metadata.test.tsx

Lines changed: 21 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
22
// SPDX-License-Identifier: Apache-2.0
33
import React from 'react';
4-
import { act, render } from '@testing-library/react';
4+
import { act, render, waitFor } from '@testing-library/react';
55

66
import {
77
activateAnalyticsMetadata,
@@ -125,7 +125,7 @@ describe('AppLayoutToolbar renders correct analytics metadata', () => {
125125
});
126126
});
127127
describe('with tools', () => {
128-
test('closed', () => {
128+
test('closed', async () => {
129129
const wrapper = renderToolbar({
130130
tools: <span>tools</span>,
131131
toolsOpen: false,
@@ -134,6 +134,9 @@ describe('AppLayoutToolbar renders correct analytics metadata', () => {
134134
toolsToggle: 'toggle tools',
135135
},
136136
});
137+
await waitFor(() => {
138+
expect(wrapper.findToolsToggle()).toBeTruthy();
139+
});
137140
const toolsTrigger = wrapper.findToolsToggle().getElement();
138141
validateComponentNameAndLabels(toolsTrigger, {});
139142
expect(getGeneratedAnalyticsMetadata(toolsTrigger)).toEqual({
@@ -144,7 +147,7 @@ describe('AppLayoutToolbar renders correct analytics metadata', () => {
144147
...getMetadata(),
145148
});
146149
});
147-
test('open', () => {
150+
test('open', async () => {
148151
const wrapper = renderToolbar({
149152
tools: <span>tools</span>,
150153
toolsOpen: true,
@@ -154,6 +157,9 @@ describe('AppLayoutToolbar renders correct analytics metadata', () => {
154157
toolsClose: 'close tools',
155158
},
156159
});
160+
await waitFor(() => {
161+
expect(wrapper.findToolsToggle()).toBeTruthy();
162+
});
157163
const toolsTrigger = wrapper.findToolsToggle().getElement();
158164
validateComponentNameAndLabels(toolsTrigger, {});
159165
expect(getGeneratedAnalyticsMetadata(toolsTrigger)).toEqual({
@@ -174,7 +180,7 @@ describe('AppLayoutToolbar renders correct analytics metadata', () => {
174180
});
175181

176182
describe('with local drawer', () => {
177-
test('closed', () => {
183+
test('closed', async () => {
178184
const wrapper = renderToolbar({
179185
drawers: [
180186
{
@@ -191,6 +197,9 @@ describe('AppLayoutToolbar renders correct analytics metadata', () => {
191197
},
192198
],
193199
});
200+
await waitFor(() => {
201+
expect(wrapper.findDrawerTriggerById('test-drawer')).toBeTruthy();
202+
});
194203
const drawerTrigger = wrapper.findDrawerTriggerById('test-drawer')!.getElement();
195204
validateComponentNameAndLabels(drawerTrigger, {});
196205
expect(getGeneratedAnalyticsMetadata(drawerTrigger)).toEqual({
@@ -201,7 +210,7 @@ describe('AppLayoutToolbar renders correct analytics metadata', () => {
201210
...getMetadata(),
202211
});
203212
});
204-
test('open', () => {
213+
test('open', async () => {
205214
const wrapper = renderToolbar({
206215
drawers: [
207216
{
@@ -232,6 +241,9 @@ describe('AppLayoutToolbar renders correct analytics metadata', () => {
232241
activeDrawerId: 'test-drawer',
233242
onDrawerChange: () => {},
234243
});
244+
await waitFor(() => {
245+
expect(wrapper.findDrawerTriggerById('test-drawer')).toBeTruthy();
246+
});
235247
const drawerTrigger = wrapper.findDrawerTriggerById('test-drawer')!.getElement();
236248
validateComponentNameAndLabels(drawerTrigger, {});
237249
expect(getGeneratedAnalyticsMetadata(drawerTrigger)).toEqual({
@@ -319,7 +331,7 @@ describe('AppLayoutToolbar renders correct analytics metadata', () => {
319331
});
320332

321333
describe('with split panel', () => {
322-
test.each(['open', 'close'])('%s', action => {
334+
test.each(['open', 'close'])('%s', async action => {
323335
const wrapper = renderToolbar({
324336
splitPanel: (
325337
<SplitPanel i18nStrings={{ openButtonAriaLabel: 'open split panel' }} header="Split panel header">
@@ -329,6 +341,9 @@ describe('AppLayoutToolbar renders correct analytics metadata', () => {
329341
splitPanelOpen: action !== 'open',
330342
onSplitPanelToggle: () => {},
331343
});
344+
await waitFor(() => {
345+
expect(wrapper.findSplitPanelOpenButton()).toBeTruthy();
346+
});
332347
const splitPanelTrigger = wrapper.findSplitPanelOpenButton()!.getElement();
333348
validateComponentNameAndLabels(splitPanelTrigger, {});
334349
expect(getGeneratedAnalyticsMetadata(splitPanelTrigger)).toEqual({

src/app-layout/visual-refresh-toolbar/skeleton/index.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@ export const SkeletonLayout = (props: RootSkeletonLayoutProps) => {
126126
navigationOpen: resolvedNavigationOpen,
127127
breadcrumbs,
128128
navigation,
129+
ariaLabels: appLayoutState?.appLayoutInternals?.ariaLabels ?? ariaLabels,
129130
},
130131
toolbarProps,
131132
registered,

0 commit comments

Comments
 (0)