Skip to content

Commit fe65778

Browse files
committed
perf: Replace use of :focus-visible shim
All targeted browsers now support :focus-visible. This commit removes the use of the shim defined in @cloudscape-design/component-toolkit. Once this change is merged, the shim can be removed.
1 parent 8c37834 commit fe65778

File tree

55 files changed

+63
-119
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+63
-119
lines changed

src/alert/styles.scss

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
@use 'sass:map';
77
@use '../internal/styles/tokens' as awsui;
88
@use '../internal/styles' as styles;
9-
@use '@cloudscape-design/component-toolkit/internal/focus-visible' as focus-visible;
109
@use '../internal/generated/custom-css-properties/index.scss' as custom-props;
1110
@use '../internal/styles/foundation' as foundation;
1211

@@ -82,7 +81,7 @@
8281
&:focus {
8382
outline: none;
8483
}
85-
@include focus-visible.when-visible {
84+
&:focus-visible {
8685
@include styles.focus-highlight(
8786
$gutter: awsui.$space-button-focus-outline-gutter,
8887
$border-radius: var(#{custom-props.$alertFocusRingBorderRadius}, awsui.$border-radius-control-default-focus-ring),

src/anchor-navigation/styles.scss

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
*/
55
@use '../internal/styles/tokens' as awsui;
66
@use '../internal/styles' as styles;
7-
@use '@cloudscape-design/component-toolkit/internal/focus-visible' as focus-visible;
87
@use '../internal/styles/typography/constants.scss' as typography;
98

109
$guide-line-width: 2px;
@@ -85,7 +84,7 @@ $guide-line-offset: -2px; // Negative to expand 2px beyond the element
8584
transition-property: all;
8685
}
8786

88-
@include focus-visible.when-visible {
87+
&:focus-visible {
8988
@include styles.link-focus;
9089
}
9190

src/annotation-context/annotation/styles.scss

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
@use '../../internal/styles/tokens' as awsui;
77
@use '../../internal/styles' as styles;
8-
@use '@cloudscape-design/component-toolkit/internal/focus-visible' as focus-visible;
98
@use '../../internal/generated/custom-css-properties/index.scss' as custom-props;
109

1110
.annotation,
@@ -69,7 +68,7 @@
6968
outline: none;
7069
}
7170

72-
@include focus-visible.when-visible {
71+
&:focus-visible {
7372
@include styles.focus-highlight(2px, awsui.$border-radius-control-circular-focus-ring);
7473
}
7574

src/app-layout/drawer/styles.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
*/
55
@use '../../internal/styles/tokens' as awsui;
66
@use '../../internal/styles' as styles;
7-
@use '@cloudscape-design/component-toolkit/internal/focus-visible' as focus-visible;
87
@use '../constants' as constants;
98

109
.toggle {

src/app-layout/toggles/styles.scss

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
@use '../../internal/styles/tokens' as awsui;
77
@use '../../internal/styles' as styles;
8-
@use '@cloudscape-design/component-toolkit/internal/focus-visible' as focus-visible;
98

109
.toggle-button {
1110
cursor: pointer;
@@ -22,7 +21,7 @@
2221
outline: none;
2322
text-decoration: none;
2423
}
25-
@include focus-visible.when-visible {
24+
&:focus-visible {
2625
@include styles.focus-highlight(awsui.$space-button-inline-icon-focus-outline-gutter);
2726
}
2827
}

src/app-layout/visual-refresh-toolbar/toolbar/trigger-button/styles.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
@use '../../../../internal/styles' as styles;
77
@use '../../../../internal/styles/tokens' as awsui;
8-
@use '@cloudscape-design/component-toolkit/internal/focus-visible' as focus-visible;
98

109
.trigger {
1110
// reset native <button> tag styles

src/app-layout/visual-refresh/trigger-button.scss

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
@use '../../internal/styles' as styles;
77
@use '../../internal/styles/tokens' as awsui;
8-
@use '@cloudscape-design/component-toolkit/internal/focus-visible' as focus-visible;
98

109
@mixin trigger-selected-styles {
1110
background: awsui.$color-background-layout-toggle-selected-default;
@@ -69,7 +68,7 @@ handleSplitPanelMaxWidth function in the context.
6968
pointer-events: auto;
7069
position: relative;
7170

72-
@include focus-visible.when-visible {
71+
&:focus-visible {
7372
@include styles.focus-highlight(3px);
7473
}
7574

src/breadcrumb-group/item/styles.scss

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
@use '../../internal/styles' as styles;
77
@use '../../internal/styles/tokens' as awsui;
8-
@use '@cloudscape-design/component-toolkit/internal/focus-visible' as focus-visible;
98

109
.link:after {
1110
display: none;
@@ -32,7 +31,7 @@
3231
display: block;
3332
}
3433

35-
@include focus-visible.when-visible {
34+
&:focus-visible {
3635
@include styles.link-focus;
3736
}
3837
}

src/breadcrumb-group/styles.scss

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
@use '../internal/styles' as styles;
77
@use '../internal/styles/tokens' as awsui;
8-
@use '@cloudscape-design/component-toolkit/internal/focus-visible' as focus-visible;
98

109
.breadcrumb-group {
1110
@include styles.styles-reset;
@@ -86,7 +85,7 @@
8685
display: flex;
8786
gap: awsui.$space-xxs;
8887
max-inline-size: 100%;
89-
@include focus-visible.when-visible {
88+
&:focus-visible {
9089
@include styles.focus-highlight(awsui.$space-button-focus-outline-gutter);
9190
}
9291
&:hover {

src/button/styles.scss

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
@use '../internal/styles/tokens' as awsui;
99
@use '../internal/styles/foundation' as foundation;
1010
@use '../internal/generated/custom-css-properties/index.scss' as custom-props;
11-
@use '@cloudscape-design/component-toolkit/internal/focus-visible' as focus-visible;
1211
@use './constants' as constants;
1312

1413
@mixin adjust-for-variant($variant) {
@@ -84,7 +83,7 @@
8483
text-decoration: none;
8584
}
8685

87-
@include focus-visible.when-visible {
86+
&:focus-visible {
8887
@include styles.focus-highlight(
8988
$gutter: awsui.$space-button-focus-outline-gutter,
9089
$border-radius: var(#{custom-props.$styleFocusRingBorderRadius}, awsui.$border-radius-control-default-focus-ring),

0 commit comments

Comments
 (0)