docs: remove limitations for new features (#435)

Remove documented limitations for new features that are now supported.

Author: olavloite

README.md

@@ -1,14 +1,14 @@
 
 # Liquibase Spanner Extension
 
-A Liquibase extension adding support for Google Cloud Spanner. Include this in your
+A Liquibase extension adding support for Google Spanner. Include this in your
 application project to run Liquibase database migration scripts against a Google
-Cloud Spanner database.
+Spanner database.
 
 ## Performance Recommendations
-Executing multiple small DDL statements on Cloud Spanner can take a very long time. This means that
+Executing multiple small DDL statements on Spanner can take a very long time. This means that
 the standard recommendation to use as small changesets as possible with Liquibase is not always the
-best choice when working with Cloud Spanner. Instead, it is recommended to create changesets that
+best choice when working with Spanner. Instead, it is recommended to create changesets that
 group multiple DDL statements into one DDL batch. Use [SQL change](https://docs.liquibase.com/change-types/community/sql.html)
 and batch the DDL using [batch statements](https://cloud.google.com/spanner/docs/jdbc-session-mgmt-commands#batch_statements).
 
@@ -235,8 +235,8 @@ See the samples directory for specific integrations with other frameworks, such
 The following Liquibase [ChangeTypes](https://docs.liquibase.com/change-types/home.html) are supported:<br/>
 createTable, dropTable, addColumn, modifyDataType, addNotNullConstraint, dropColumn, createIndex, dropIndex, addForeignKeyConstraint, dropForeignKeyConstraint, dropAllForeignKeyConstraints, addLookupTable, createView, dropView
 
-The following Liquibase [ChangeTypes](https://docs.liquibase.com/change-types/home.html) are not allowed with Cloud Spanner:<br/>
-addAutoIncrement, addDefaultValue, addPrimaryKey, addUniqueConstraint, dropUniqueConstraint, createProcedure, dropDefaultValue, dropNotNullConstraint, dropPrimaryKey, dropProcedure, renameColumn, renameSequence, renameTable, renameView, setColumnRemarks, setTableRemarks, alterSequence
+The following Liquibase [ChangeTypes](https://docs.liquibase.com/change-types/home.html) are not allowed with Spanner:<br/>
+addAutoIncrement, addPrimaryKey, addUniqueConstraint, dropUniqueConstraint, createProcedure, dropNotNullConstraint, dropPrimaryKey, dropProcedure, renameColumn, renameSequence, renameView, setColumnRemarks, setTableRemarks, alterSequence
 
 The following data DML [ChangeTypes](https://docs.liquibase.com/change-types/home.html) are supported:<br/>
 insert, update, loadData, loadUpdateData
@@ -274,7 +274,7 @@ delete.
 
 ### Unsupported Spanner Features
 
-There are a number of features that Spanner does not have such as sequences and stored procedures. The Liquibase extension will
+There are a number of features that Spanner does not have such as stored procedures. The Liquibase extension will
 throw an exception during analysis of the changeSet in most cases, but not all. For example, a DELETE without a WHERE clause
 will fail in Spanner but not in the Liquibase extension.
 
@@ -292,7 +292,7 @@ will fail in Spanner but not in the Liquibase extension.
 Testing requirements:
  * Emulator requires [testcontainers](https://www.testcontainers.org/) and its [requirements](https://www.testcontainers.org/supported_docker_environment/) installed.
  * Spanner in GCP requires SPANNER_PROJECT and SPANNER_INSTANCE environment variables set to an active instance
- * Spanner in GCP requires application default credentials set or GOOGLE_APPLICATION_CREDENTIALS environent set
+ * Spanner in GCP requires application default credentials set or GOOGLE_APPLICATION_CREDENTIALS environment set
 
 ### Deploying
 

limitations.md

@@ -1,10 +1,10 @@
 # Limitations
-This library implements as many available features of both Liquibase and Cloud Spanner as possible. However, there
+This library implements as many available features of both Liquibase and Spanner as possible. However, there
 are a number of features that either can't be supported, or that can only be supported through custom SQL changes.
 These limitations and possible workarounds are listed in this document.
 
-## Cloud Spanner features without a corresponding Liquibase change type
-The following Cloud Spanner features do not have a corresponding change type in Liquibase and are, therefore,
+## Spanner features without a corresponding Liquibase change type
+The following Spanner features do not have a corresponding change type in Liquibase and are, therefore,
 only supported through custom SQL change sets or through automatic modification of the SQL statements that are
 generated by Liquibase.
 
@@ -16,30 +16,27 @@ to modify the generated SQL. See the [create-schema.yaml](example/create-schema.
 - Commit timestamp columns: Use `ModifySql` to replace the column definition with one that includes the `OPTIONS (allow_commit_timestamp=true)` clause. See [create-schema.yaml](example/create-schema.yaml) for an example.
 - Null-filtered indexes: Use `ModifySql` to replace the `CREATE INDEX` statement with `CREATE NULL_FILTERED INDEX`. See [this test file](src/test/resources/create-null-filtered-index-singers-first-name.spanner.yaml) for an example.
 
-## Database features not supported by Cloud Spanner
-The following database features are not supported by Cloud Spanner, and trying to create/alter/drop any of them through Liquibase will cause an error.
+## Database features not supported by Spanner
+The following database features are not supported by Spanner, and trying to create/alter/drop any of them through Liquibase will cause an error.
 
-- Auto increment columns
-- Sequences
 - Unique constraints: Use `UNIQUE INDEX` instead of `UNIQUE CONSTRAINT`
 - Stored procedures
 - Table and column remarks
 
-## Liquibase change types with no Cloud Spanner support
-The following change types are not supported by Cloud Spanner.
-- Add/Drop primary key: Cloud Spanner requires that all tables have a primary key. The primary key must be defined when the table is created, and cannot be dropped or added later.
-- Rename table: Cloud Spanner does not support renaming tables. Create a copy instead, and drop the old table.
-- Rename column: Cloud Spanner does not support renaming columns. Create a copy instead, and drop the old column.
+## Liquibase change types with no Spanner support
+The following change types are not supported by Spanner.
+- Add/Drop primary key: Spanner requires that all tables have a primary key. The primary key must be defined when the table is created, and cannot be dropped or added later.
+- Rename column: Spanner does not support renaming columns. Create a copy instead, and drop the old column.
 
-## Liquibase change types with limited Cloud Spanner support
-The following Liquibase change types are implemented for Cloud Spanner but have certain limitations.
+## Liquibase change types with limited Spanner support
+The following Liquibase change types are implemented for Spanner but have certain limitations.
 
-- AddLookupTable: This feature is implemented and works for most cases. However, if the amount of data to be inserted in the new lookup table exceeds any of the [Cloud Spanner transaction limits](https://cloud.google.com/spanner/docs/dml-tasks#transaction_limits), the change will fail and you should implement it using a custom SQL change.
-- Delete: This feature is implemented and works for most cases. However, if the amount of data to be deleted in the new lookup table exceeds any of the [Cloud Spanner transaction limits](https://cloud.google.com/spanner/docs/dml-tasks#transaction_limits), the change will fail and you should implement it using a custom SQL change. Specifying a `WHERE` clause for the `DELETE` statement is required (the clause may be `WHERE TRUE`).
-- Load data / Load-update data: These features are implemented and works for most cases. If however the amount of data to be inserted or updated exceeds any of the [Cloud Spanner transaction limits](https://cloud.google.com/spanner/docs/dml-tasks#transaction_limits), the change will fail and you should implement it using a custom SQL change.
-- Modify data type: This feature works, but only for the data type changes that are [allowed by Cloud Spanner](https://cloud.google.com/spanner/docs/data-definition-language#description_3).
+- AddLookupTable: This feature is implemented and works for most cases. However, if the amount of data to be inserted in the new lookup table exceeds any of the [Spanner transaction limits](https://cloud.google.com/spanner/docs/dml-tasks#transaction_limits), the change will fail and you should implement it using a custom SQL change.
+- Delete: This feature is implemented and works for most cases. However, if the amount of data to be deleted in the new lookup table exceeds any of the [Spanner transaction limits](https://cloud.google.com/spanner/docs/dml-tasks#transaction_limits), the change will fail and you should implement it using a custom SQL change. Specifying a `WHERE` clause for the `DELETE` statement is required (the clause may be `WHERE TRUE`).
+- Load data / Load-update data: These features are implemented and works for most cases. If however the amount of data to be inserted or updated exceeds any of the [Spanner transaction limits](https://cloud.google.com/spanner/docs/dml-tasks#transaction_limits), the change will fail and you should implement it using a custom SQL change.
+- Modify data type: This feature works, but only for the data type changes that are [allowed by Spanner](https://cloud.google.com/spanner/docs/data-definition-language#description_3).
 
-A potential work-around for the transaction limits in Cloud Spanner is to use [Partitioned DML](https://cloud.google.com/spanner/docs/dml-tasks#partitioned-dml) instead of transactional DML. Partitioned DML statements are not bound by the transaction limits, but are also not atomic. The Cloud Spanner JDBC driver that is used by Liquibase supports Partitioned DML by setting the `AUTOCOMMIT_DML_MODE` connection property to `PARTITIONED_NON_ATOMIC`:
+A potential work-around for the transaction limits in Spanner is to use [Partitioned DML](https://cloud.google.com/spanner/docs/dml-tasks#partitioned-dml) instead of transactional DML. Partitioned DML statements are not bound by the transaction limits, but are also not atomic. The Spanner JDBC driver that is used by Liquibase supports Partitioned DML by setting the `AUTOCOMMIT_DML_MODE` connection property to `PARTITIONED_NON_ATOMIC`:
 
 ```sql
 SET AUTOCOMMIT = TRUE;
@@ -53,4 +50,4 @@ SET AUTOCOMMIT_DML_MODE = 'TRANSACTIONAL';
 
 ## DDL limits
 
-Cloud Spanner recommends some [best practices for schema updates](https://cloud.google.com/spanner/docs/schema-updates#best-practices) including limiting the frequency of schema updates and to consider the impact of large scale schema changes. One approach it to apply a small number of change sets. Alternatively, use [SQL change](https://docs.liquibase.com/change-types/community/sql.html) and batch the DDL using [batch statements](https://cloud.google.com/spanner/docs/use-oss-jdbc#batch_statements).
+Spanner recommends some [best practices for schema updates](https://cloud.google.com/spanner/docs/schema-updates#best-practices) including limiting the frequency of schema updates and to consider the impact of large scale schema changes. One approach it to apply a small number of change sets. Alternatively, use [SQL change](https://docs.liquibase.com/change-types/community/sql.html) and batch the DDL using [batch statements](https://cloud.google.com/spanner/docs/use-oss-jdbc#batch_statements).