make directory flag required (#137)

* make directory flag required

Signed-off-by: sivchari <shibuuuu5@gmail.com>

* handle CustomFileSystemFunc and add test cases

Signed-off-by: sivchari <shibuuuu5@gmail.com>

---------

Signed-off-by: sivchari <shibuuuu5@gmail.com>

Author: sivchari

cmd/root.go

@@ -59,7 +59,11 @@ var rootCmd = &cobra.Command{
 			ctx = wrenchfs.WithContext(ctx, CustomFileSystemFunc())
 			cmd.SetContext(ctx)
 		}
-
+		if CustomFileSystemFunc == nil {
+			if err := cobra.MarkFlagRequired(cmd.PersistentFlags(), flagNameDirectory); err != nil {
+				panic(err)
+			}
+		}
 		return nil
 	},
 }
@@ -83,11 +87,11 @@ func init() {
 	rootCmd.AddCommand(truncateCmd)
 	rootCmd.AddCommand(instanceCmd)
 
-	rootCmd.PersistentFlags().StringVar(&project, flagNameProject, spannerProjectID(), "GCP project id (optional. if not set, will use $SPANNER_PROJECT_ID or $GOOGLE_CLOUD_PROJECT value)")
-	rootCmd.PersistentFlags().StringVar(&instance, flagNameInstance, spannerInstanceID(), "Cloud Spanner instance name (optional. if not set, will use $SPANNER_INSTANCE_ID value)")
-	rootCmd.PersistentFlags().StringVar(&database, flagNameDatabase, spannerDatabaseID(), "Cloud Spanner database name (optional. if not set, will use $SPANNER_DATABASE_ID value)")
-	rootCmd.PersistentFlags().StringVar(&directory, flagNameDirectory, "", "Directory that schema file placed (required)")
-	rootCmd.PersistentFlags().StringVar(&schemaFile, flagNameSchemaFile, "", "Name of schema file (optional. if not set, will use default 'schema.sql' file name)")
+	rootCmd.PersistentFlags().StringVar(&project, flagNameProject, spannerProjectID(), "GCP project id. If not set, will use $SPANNER_PROJECT_ID or $GOOGLE_CLOUD_PROJECT value")
+	rootCmd.PersistentFlags().StringVar(&instance, flagNameInstance, spannerInstanceID(), "Cloud Spanner instance name. If not set, will use $SPANNER_INSTANCE_ID value")
+	rootCmd.PersistentFlags().StringVar(&database, flagNameDatabase, spannerDatabaseID(), "Cloud Spanner database name If not set, will use $SPANNER_DATABASE_ID value")
+	rootCmd.PersistentFlags().StringVar(&directory, flagNameDirectory, "", "Directory that schema file placed")
+	rootCmd.PersistentFlags().StringVar(&schemaFile, flagNameSchemaFile, "", "Name of schema file If not set, will use default 'schema.sql' file name")
 	rootCmd.PersistentFlags().StringVar(&credentialsFile, flagCredentialsFile, "", "Specify Credentials File")
 	rootCmd.PersistentFlags().DurationVar(&timeout, flagTimeout, time.Hour, "Context timeout")
 

cmd/root_test.go

@@ -0,0 +1,45 @@
+package cmd
+
+import (
+	"testing"
+
+	"github.com/spf13/cobra"
+)
+
+func TestDirectoryFlagNilAndCustomFileSystemFuncIsNil(t *testing.T) {
+	rootCmd.RunE = func(cmd *cobra.Command, args []string) error {
+		return nil
+	}
+
+	testcases := []struct {
+		name  string
+		flags []string
+		want  bool
+	}{
+		{
+			name:  "directory flag is nil and CustomFileSystemFunc is nil",
+			flags: []string{},
+			want:  true,
+		},
+		{
+			name:  "directory flag is set and CustomFileSystemFunc is nil",
+			flags: []string{"--directory", "test"},
+			want:  false,
+		},
+		{
+			name:  "directory flag is nil and CustomFileSystemFunc is set",
+			flags: []string{},
+			want:  false,
+		},
+	}
+
+	for _, tc := range testcases {
+		t.Run(tc.name, func(t *testing.T) {
+			rootCmd.SetArgs(tc.flags)
+			err := rootCmd.Execute()
+			if (err != nil) != tc.want {
+				t.Errorf("Execute() error = %v, wantErr %v", err, tc.want)
+			}
+		})
+	}
+}