Skip to content

Commit d3d9754

Browse files
committed
Review comments addressed
1 parent 9f9eafd commit d3d9754

File tree

3 files changed

+16
-12
lines changed

3 files changed

+16
-12
lines changed

cdap-e2e-tests/src/e2e-test/features/namespaceadmin/NSAdminDesignTime.feature

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,20 +17,28 @@
1717
Feature: NameSpaceAdmin - Validate nameSpace admin design time scenarios
1818

1919
@Namespaceadmin
20-
Scenario:Verify user is able to click the nameSpace admin tab and successfully navigates to the page
20+
Scenario:Verify user is able to click on the namespace admin tab and successfully navigates to the page
2121
Given Open Datafusion Project to configure pipeline
2222
When Click on the Hamburger bar on the left panel
2323
Then Click on NameSpace Admin link from the menu
2424
Then Verify that the user is navigated to nameSpace admin page successfully
2525

2626
@Namespaceadmin
27-
Scenario:Validate user is able to open compute profile page and select a provisioner
27+
Scenario:Validate user is able to open compute profile page and create a profile for selected a provisioner
2828
Given Open Datafusion Project to configure pipeline
2929
Then Click on the Hamburger bar on the left panel
3030
Then Click on NameSpace Admin link from the menu
3131
Then Click on create profile button for "default" Namespace
32-
Then Select a provisioner: "existingDataProc" for the compute profile
33-
Then Click on close button of compute profile properties page
32+
Then Select a provisioner: "remoteHadoopProvisioner" for the compute profile
33+
Then Verify the Create a Profile page is loaded for selected provisioner
34+
Then Enter input plugin property: "profileLabel" with value: "validProfile"
35+
Then Enter textarea plugin property: "profileDescription" with value: "validDescription"
36+
Then Enter input plugin property: "host" with value: "testHost"
37+
Then Enter input plugin property: "user" with value: "testUser"
38+
Then Enter textarea plugin property: "sshKey" with value: "testSSHKey"
39+
Then Click on: "Create" button in the properties
40+
Then Verify the created compute profile: "validProfile" is displayed in system compute profile list
41+
3442

3543
@Namespaceadmin
3644
Scenario: Validate user is able to create new namespace preferences and able to delete the added namespace preferences successfully

cdap-e2e-tests/src/e2e-test/features/namespaceadmin/NSAdminRunTime.feature

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
Feature: NameSpaceAdmin - Validate nameSpace admin run time scenarios
1818

1919
@BQ_SOURCE_TEST @BQ_SINK_TEST
20-
Scenario:To verify user should be able to run a pipeline successfully using the NameSpace preferences created
20+
Scenario:To verify if user is able to run a pipeline successfully using the namespace preferences
2121
Given Open Datafusion Project to configure pipeline
2222
Then Click on the Hamburger bar on the left panel
2323
Then Click on NameSpace Admin link from the menu
@@ -56,7 +56,7 @@ Feature: NameSpaceAdmin - Validate nameSpace admin run time scenarios
5656
Then Verify the pipeline status is "Succeeded"
5757

5858
@BQ_SOURCE_TEST @BQ_SINK_TEST
59-
Scenario: To verify User should be able to create a test connection inside Namespace admin and use it in any of the selected plugin Property.
59+
Scenario: To verify if user is able to create a connection from namespace admin and configure it for required plugins
6060
Given Open Datafusion Project to configure pipeline
6161
Then Click on the Hamburger bar on the left panel
6262
Then Click on NameSpace Admin link from the menu
@@ -101,5 +101,3 @@ Feature: NameSpaceAdmin - Validate nameSpace admin run time scenarios
101101
Then Wait till pipeline is in running state
102102
Then Open and capture logs
103103
Then Verify the pipeline status is "Succeeded"
104-
105-

cdap-e2e-tests/src/e2e-test/resources/pluginParameters.properties

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,8 @@ invalidNamespaceName=^%&&3%%
1414
validNamespaceDescription=Test Description
1515
invalidProfile=6*&gjh879
1616
invalidClusterName=$^%%&^GHJJH89
17-
validNamespaceName=AutoTestt
17+
validNamespaceName=AutoTest
1818
ConnectionName=TestConnection
1919
projectId=cdf-athena
2020
dataset=test_automation
21-
#bqSourceTable=dummy
22-
#bqTargetTable=dummy
23-
## NAMESPACEADMIN-PROPERTIES-END
21+
## NAMESPACEADMIN-PROPERTIES-END

0 commit comments

Comments
 (0)