Skip to content

Commit 0db39ec

Browse files
Fixed errors in parameterMap
1 parent ddf3ae1 commit 0db39ec

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

src/main/java/io/cdap/plugin/gcp/bigquery/source/PartitionedBigQueryInputFormat.java

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -274,18 +274,24 @@ private static void runQuery(Configuration configuration,
274274
Map<String, String> parameterMap = ConfigUtil.parseKeyValueConfig(parameterMapString, ",", "=");
275275
List<QueryParameter> queryParameters = new ArrayList<>();
276276
FieldList fieldList = bqTable.getDefinition().getSchema().getFields();
277-
for (String columnName : parameterMap.keySet()) {
277+
for (String alias : parameterMap.keySet()) {
278+
String raw = parameterMap.get(alias); // "sys_updated_on=2018-12-11T23"
279+
String[] parts = raw.split("=", 2); // [ "sys_updated_on", "2018-12-11T23" ]
280+
281+
String columnName = parts[0];
282+
String rawValue = parts[1];
283+
278284
String parameterType = fieldList.get(columnName).getType().name();
279-
String rawValue = parameterMap.get(columnName);
280285
String normalizedValue = normalizeValueForBigQuery(parameterType, rawValue);
281286

282287
QueryParameter queryParameter = new QueryParameter()
283-
.setName(columnName)
288+
.setName(alias)
284289
.setParameterType(new QueryParameterType().setType(parameterType))
285290
.setParameterValue(new QueryParameterValue().setValue(normalizedValue));
286291

287292
queryParameters.add(queryParameter);
288293
}
294+
289295
queryConfig.setParameterMode("NAMED");
290296
queryConfig.setQueryParameters(queryParameters);
291297
}

widgets/BigQueryTable-batchsource.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@
157157
"name": "parameterMap",
158158
"widget-attributes": {
159159
"delimiter": ",",
160-
"values-delimiter": ":",
160+
"values-delimiter": "=",
161161
"numValues": "3",
162162
"placeholders": [
163163
"Field Alias",

0 commit comments

Comments
 (0)