fix: max_iter with config.max_steps

gwkrsrch · gwkrsrch · commit 4130973482c5 · 2022-07-29T15:06:18.000Z
diff --git a/lightning_module.py b/lightning_module.py
@@ -114,7 +114,7 @@ def configure_optimizers(self):
             )
 
         if self.config.get("max_steps", None):
-            max_iter = min(self.config.max_steps, max_iter)
+            max_iter = min(self.config.max_steps, max_iter) if max_iter is not None else self.config.max_steps
 
         assert max_iter is not None
         optimizer = torch.optim.Adam(self.parameters(), lr=self.config.lr)

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ def configure_optimizers(self):`
`114`	`114`	`)`
`115`	`115`
`116`	`116`	`if self.config.get("max_steps", None):`
`117`		`- max_iter = min(self.config.max_steps, max_iter)`
	`117`	`+ max_iter = min(self.config.max_steps, max_iter) if max_iter is not None else self.config.max_steps`
`118`	`118`
`119`	`119`	`assert max_iter is not None`
`120`	`120`	`optimizer = torch.optim.Adam(self.parameters(), lr=self.config.lr)`