File "CREATED" status should prevent user download / notify user why they can't download (#175)

* Disable the "Download" button for files that have a status of CREATED

* Add a banner to call more attention that the file is in-transit

* Disable per-File Download button on Dataset and Folder views when file is only CREATED

Co-authored-by: Luigi Marini <[email protected]>

Author: bodom0015

CHANGELOG.md

@@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## Unreleased
 
+### Fixed
+- Clowder will no longer offer a Download button for a file until it has been PROCESSED.
+
 ### Changed
 - `/api/me` will now return some of the same information as response headers.
 

app/views/file.scala.html

@@ -268,6 +268,23 @@ <h1 id="file-name-title" class="inline break-word"> <span class="glyphicon glyph
 					}
 				</div>
 			</div>
+			@if(file.status == "CREATED") {
+				<div class="alert alert-warning">
+					<div class="row">
+						<div class="col-sm-11">
+							<strong>Warning!</strong>
+							This file is still in transit, so the file bytes are not yet available.
+							<p>You can still attach metadata and comments below.</p>
+						</div>
+						<div class="col-sm-1">
+							<button type="button" class="close" data-dismiss="alert" aria-label="Close">
+								<span aria-hidden="true">&times;</span>
+							</button>
+						</div>
+					</div>
+
+				</div>
+			}
 			@for((f, pvs) <- previews) {
 				<div class="row" id="filePrevContainer_@(f.id.toString)" data-previewsCount="@(pvs.length)" data-filename="@f.filename">
 					<div class="col-md-12">
@@ -316,13 +333,19 @@ <h4>No previews currently available for this file</h4>
 					<div class="col-md-12">
 						<hr/>
 						<div class="btn-group" role="group" aria-label="...">
-							@if( Permission.checkPermission(Permission.DownloadFiles, ResourceRef(ResourceRef.file, file.id))) {
-								<button id="downloadButton" type="button" onclick="return downloadFile();" class="btn btn-link" title="Download and enjoy this file."> <span class="glyphicon glyphicon-save"></span>
+							@if(file.status == "CREATED") {
+								<!-- if 'disabled' title is not visible -->
+								<button type="button" class="btn btn-link disabled" title="Please wait for the file to finish processing."> <span class="glyphicon glyphicon-save"></span>
 									Download </button>
 							} else {
+								@if(!Permission.checkPermission(Permission.DownloadFiles, ResourceRef(ResourceRef.file, file.id))) {
 									<!-- if 'disabled' title is not visible -->
-								<button type="button" class="btn btn-link disabled" title="You don't have permission to download this file."> <span class="glyphicon glyphicon-save"></span>
-									Download </button>
+									<button type="button" class="btn btn-link disabled" title="You don't have permission to download this file."> <span class="glyphicon glyphicon-save"></span>
+										Download </button>
+								} else {
+									<button id="downloadButton" type="button" onclick="return downloadFile();" class="btn btn-link" title="Download and enjoy this file."> <span class="glyphicon glyphicon-save"></span>
+										Download </button>
+								}
 							}
 							@if( play.Play.application().configuration().getBoolean("archiveEnabled")) {
 								@if( Permission.checkPermission(Permission.ArchiveFile, ResourceRef(ResourceRef.file, file.id))) {

app/views/files/listitem.scala.html

@@ -55,18 +55,26 @@ <h3><a href="@(routes.Files.file(file.id, dataset, space, folder))" class="break
                     </div>
                     <div class="col-md-4 col-lg-4 col-sm-4">
                         <ul class="list-unstyled">
-                            @if( Permission.checkPermission(Permission.DownloadFiles, ResourceRef(ResourceRef.file, file.id))) {
+                            @if( file.status == "CREATED" ) {
                                 <li>
-                                    <button id="downloadButton" onclick="window.open(jsRoutes.api.Files.download('@file.id').url, '_blank');" class="btn btn-link" title="Download and enjoy this file.">
-                                        <span class="glyphicon glyphicon-save"></span> Download
-                                    </button>
-                                </li>
-                            } else {
-                                <li>
-                                    <div class="inline" title="No permission to download the file">
-                                        <button disabled class="btn btn-link"><span class="glyphicon glyphicon-save"></span> Download</button>
+                                    <div class="inline" title="Please wait for the file to finish processing.">
+                                        <button class="btn btn-link disabled"><span class="glyphicon glyphicon-save"></span> Download</button>
                                     </div>
                                 </li>
+                            } else {
+                                @if( Permission.checkPermission(Permission.DownloadFiles, ResourceRef(ResourceRef.file, file.id))) {
+                                    <li>
+                                        <button id="downloadButton" onclick="window.open(jsRoutes.api.Files.download('@file.id').url, '_blank');" class="btn btn-link" title="Download and enjoy this file.">
+                                            <span class="glyphicon glyphicon-save"></span> Download
+                                        </button>
+                                    </li>
+                                } else {
+                                    <li>
+                                        <div class="inline" title="No permission to download the file">
+                                            <button disabled class="btn btn-link"><span class="glyphicon glyphicon-save"></span> Download</button>
+                                        </div>
+                                    </li>
+                                }
                             }
 
                             @user match {