Metadata tab select (#126)

* 1char fix to mongo-init

* added name to contributors

* permission change compiles

* select metadata if no files

* restore permission change

* if no hash test if can set metadata

* use tabsInURL.js

* split out hash part till can be tested

* split out url-hash till better tested

* tab- > space reformat

* same logic to get: tab-pane fade in active, too

* Dataset page usually defaults to Files tab, but if no files will now show Metadata first

* combine added

Co-authored-by: Luigi Marini <[email protected]>

Author: MBcode

CHANGELOG.md

@@ -18,6 +18,7 @@ script prior to upgrading to minimize the downtime.
 ### Added
 - api.Files jsonfile, adds two fields "downloads" and "views" [#228](https://github.com/clowder-framework/clowder/issues/228)
 - MRI previewer for NIFTY (.nii) files.
+- Dataset page usually defaults to Files tab, but if no files will now show Metadata first
 - HEIC (.heic) and HEIF (.heif) mimetypes to support new Apple iPhone image file format.
 - In the docker container the folder /home/clowder/data is now whitelisted by default for uploading by reference. 
   This can be changed using the environment variable CLOWDER_SOURCEPATH.

app/views/dataset.scala.html

@@ -287,17 +287,26 @@ <h4 class="modal-title" id="folder-modal-label">  @Messages("create.header", "Fo
 
 	    	<div class="tabbable" id="bottomDatasetTabbable"> <!-- Only required for left/right tabs -->
                 <ul class="nav nav-tabs margin-bottom-20" >
-                    <li role="presentation" class="active"><a href="#tab-files" role="tab" data-toggle="tab">Files </a></li>
-                    <li role="presentation"><a href="#tab-metadata" role="tab" data-toggle="tab">Metadata </a></li>
-                    <li role="presentation"><a href="#tab-extractions" role="tab" data-toggle="tab">Extractions </a></li>
-                    <li role="presentation"><a href="#tab-visua" role="tab" data-toggle="tab">Visualizations</a></li>
-                    <li role="presentation"><a href="#tab-comments" role="tab" data-toggle="tab">Comments (@comments.size)</a></li>
+                    @if(dataset.files.isEmpty && (m.size > 0)) {
+                    <li role="presentation"><a href="#tab-files" id="files" role="tab" data-toggle="tab">Files </a></li>
+                    <li role="presentation" class="active"><a href="#tab-metadata" id="metadata" role="tab" data-toggle="tab">Metadata </a></li>
+                    } else {
+                    <li role="presentation" class="active"><a href="#tab-files" id="files" role="tab" data-toggle="tab">Files </a></li>
+                    <li role="presentation"><a href="#tab-metadata" id="metadata" role="tab" data-toggle="tab">Metadata </a></li>
+										} 
+                    <li role="presentation"><a href="#tab-extractions" id="extractions" role="tab" data-toggle="tab">Extractions </a></li>
+                    <li role="presentation"><a href="#tab-visua" id="visua" role="tab" data-toggle="tab">Visualizations</a></li>
+                    <li role="presentation"><a href="#tab-comments" id="comments" role="tab" data-toggle="tab">Comments (@comments.size)</a></li>
                     @if(relatedDataset.size > 0) {
                         <li role="relation"><a href="#tab-relations" role="tab" data-toggle="tab">Related</a></li>
                     }
                 </ul>
                 <div class="tab-content">
+                    @if(dataset.files.isEmpty && (m.size > 0)) {
+                    <div role="tabpanel" class="tab-pane fade" id="tab-files">
+                    } else {
                     <div role="tabpanel" class="tab-pane fade in active" id="tab-files">
+										}
                         <div id="loading-spinner" class="center-glyphicon valign-link">
                             <span class="glyphicon glyphicon-refresh glyphicon-animation-spin glyphicon-5x"></span>
                             <span class="sr-only">Loading...</span>
@@ -310,7 +319,11 @@ <h4 class="modal-title" id="folder-modal-label">  @Messages("create.header", "Fo
                         }
                         <div class="list-unstyled" id="[email protected]"> @comment(comments)</div>
                     </div>
+                    @if(dataset.files.isEmpty && (m.size > 0)) {
+                    <div role="tabpanel" class="tab-pane fade in active" id="tab-metadata">
+                    } else {
                     <div role="tabpanel" class="tab-pane fade" id="tab-metadata">
+										}
                         @if(user.isDefined) {
                             <div class="row">
                                 <div class="col-md-12">
@@ -371,8 +384,9 @@ <h4>Statistics</h4>
 		</div>
 	</div>
 
+    @* FIXME tabsInURL.js Commented out since it creates some issues with dataset previewers *@
     @* FIXME Commented out since it creates some issues with dataset previewers *@
-    @*<script src="@routes.Assets.at("javascripts/tabsInURL.js")" type="text/javascript"></script>*@
+    @* <script src="@routes.Assets.at("javascripts/tabsInURL.js")" type="text/javascript"></script> *@
     <script src="@routes.Assets.at("javascripts/errorRedirect.js")" type="text/javascript"></script>
     <script src="@routes.Assets.at("javascripts/updateLicenseInfo.js")" language="javascript"></script>
     <script src="@routes.Assets.at("javascripts/datasetListProcess.js")" type="text/javascript"></script>
@@ -871,5 +885,4 @@ <h4>Statistics</h4>
         }
 
     </script>
-}
-
+}