Skip to content

Commit feb8cdb

Browse files
authored
secrets can not be used in if
1 parent 7fe6fa0 commit feb8cdb

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

.github/workflows/docker.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@ env:
2929
jobs:
3030
docker:
3131
runs-on: ubuntu-latest
32+
env:
33+
dockerhub: ${{ secrets.DOCKERHUB_USERNAME }}
3234
permissions:
3335
packages: write
3436
strategy:
@@ -129,7 +131,7 @@ jobs:
129131
130132
# login to registries
131133
- name: Login to DockerHub
132-
if: secrets.DOCKERHUB_USERNAME != ""
134+
if: env.dockerhub != ''
133135
uses: docker/login-action@v2
134136
with:
135137
username: ${{ secrets.DOCKERHUB_USERNAME }}
@@ -196,7 +198,7 @@ jobs:
196198
197199
# update README at DockerHub
198200
- name: Docker Hub Description
199-
if: matrix.README != '' && github.event_name == 'push' && github.repository == env.MASTER_REPO && env.BRANCH == 'master'
201+
if: env.dockerhub != '' && matrix.README != '' && github.event_name == 'push' && github.repository == env.MASTER_REPO && env.BRANCH == 'master'
200202
uses: peter-evans/dockerhub-description@v2
201203
env:
202204
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}

0 commit comments

Comments
 (0)