Skip to content

Commit 87d180a

Browse files
authored
Fixing logic to post metadata on file upload (#1054)
* Fixing logic to post metadata on file upload * removing location.reload
1 parent 12e54f1 commit 87d180a

File tree

5 files changed

+11
-451
lines changed

5 files changed

+11
-451
lines changed

frontend/src/components/datasets/Dataset.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,7 @@ export const Dataset = (): JSX.Element => {
138138
);
139139
const adminMode = useSelector((state: RootState) => state.user.adminMode);
140140
const license = useSelector((state: RootState) => state.dataset.license);
141+
const newFiles = useSelector((state: RootState) => state.dataset.newFiles);
141142
const deletedFile = useSelector(
142143
(state: RootState) => state.dataset.deletedFile
143144
);
@@ -170,7 +171,7 @@ export const Dataset = (): JSX.Element => {
170171
listDatasetLicense(about.license_id);
171172
getFolderPath(folderId);
172173
getMetadatDefinitions(null, 0, 100);
173-
}, [searchParams, adminMode, about.license_id]);
174+
}, [searchParams, adminMode, about.license_id, newFiles]);
174175

175176
useEffect(() => {
176177
fetchFoldersFilesInDataset(

frontend/src/components/datasets/NewMenu.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ import { CreateFolder } from "../folders/CreateFolder";
1212
import React from "react";
1313
import { useSelector } from "react-redux";
1414
import { RootState } from "../../types/data";
15-
import { UploadFile } from "../files/UploadFile";
16-
import { UploadFileMultiple } from "../files/UploadFileMultiple";
1715
import { UploadFileDragAndDrop } from "../files/UploadFileDragAndDrop";
1816
import UploadIcon from "@mui/icons-material/Upload";
1917
import { Folder } from "@material-ui/icons";
@@ -57,6 +55,7 @@ export const NewMenu = (props: ActionsMenuProps): JSX.Element => {
5755
<UploadFileDragAndDrop
5856
selectedDatasetId={datasetId}
5957
folderId={folderId}
58+
setDragDropFiles={setDragDropFiles}
6059
/>
6160
</Dialog>
6261

frontend/src/components/files/UploadFile.tsx

Lines changed: 0 additions & 224 deletions
This file was deleted.

frontend/src/components/files/UploadFileDragAndDrop.tsx

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,13 @@ import FileUploadDrop from "./FileUploadDrop";
3030
type UploadFileDragAndDropProps = {
3131
selectedDatasetId: string | undefined;
3232
folderId: string | undefined;
33+
setDragDropFiles: any;
3334
};
3435

3536
export const UploadFileDragAndDrop: React.FC<UploadFileDragAndDropProps> = (
3637
props: UploadFileDragAndDropProps
3738
) => {
38-
const { selectedDatasetId, folderId } = props;
39+
const { selectedDatasetId, folderId, setDragDropFiles } = props;
3940
const [selectedFiles, setSelectedFiles] = useState<File[]>([]);
4041
const [metadataRequestForms, setMetadataRequestForms] = useState({});
4142
const [allFilled, setAllFilled] = React.useState<boolean>(false);
@@ -53,7 +54,9 @@ export const UploadFileDragAndDrop: React.FC<UploadFileDragAndDropProps> = (
5354
const createFileMetadata = (
5455
fileId: string | undefined,
5556
metadata: MetadataIn
56-
) => dispatch(postFileMetadata(fileId, metadata));
57+
) => {
58+
dispatch(postFileMetadata(fileId, metadata));
59+
};
5760

5861
const uploadFiles = (
5962
selectedDatasetId: string | undefined,
@@ -157,9 +160,9 @@ export const UploadFileDragAndDrop: React.FC<UploadFileDragAndDropProps> = (
157160

158161
useEffect(() => {
159162
if (newFiles.length > 0) {
160-
newFiles.map((file) => {
163+
newFiles.forEach((file) => {
161164
// post new metadata
162-
Object.keys(metadataRequestForms).map((key) => {
165+
Object.keys(metadataRequestForms).forEach((key) => {
163166
createFileMetadata(file.id, metadataRequestForms[key]);
164167
});
165168
});
@@ -171,8 +174,7 @@ export const UploadFileDragAndDrop: React.FC<UploadFileDragAndDropProps> = (
171174
// Stop spinner
172175
setLoading(false);
173176

174-
// go back to the dataset
175-
location.reload();
177+
setDragDropFiles(false);
176178
}
177179
}, [newFiles]);
178180

0 commit comments

Comments
 (0)