Skip to content

Commit bc85a42

Browse files
authored
add metadata button is back (#888)
* add metadata button is back * button is back in * remove console log * datasetRole !== undefined check, not datasetRole.role That will break if it is undefined * check if datasetRole.role is defined
1 parent fd7ee00 commit bc85a42

File tree

2 files changed

+18
-13
lines changed

2 files changed

+18
-13
lines changed

frontend/src/components/files/File.tsx

Lines changed: 17 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@ export const File = (): JSX.Element => {
275275
} else if (showNotFoundPage) {
276276
return <PageNotFound />;
277277
}
278-
278+
279279
return (
280280
<Layout>
281281
{/*Error Message dialogue*/}
@@ -407,17 +407,22 @@ export const File = (): JSX.Element => {
407407
resourceType="file"
408408
resourceId={fileId}
409409
/>
410-
<Box textAlign="center">
411-
<Button
412-
variant="contained"
413-
sx={{ m: 2 }}
414-
onClick={() => {
415-
setEnableAddMetadata(true);
416-
}}
417-
>
418-
Add Metadata
419-
</Button>
420-
</Box>
410+
{fileRole !== undefined && fileRole!== "viewer"?
411+
(
412+
<Box textAlign="center">
413+
<Button
414+
variant="contained"
415+
sx={{ m: 2 }}
416+
onClick={() => {
417+
setEnableAddMetadata(true);
418+
}}
419+
>
420+
Add Metadata
421+
</Button>
422+
</Box>
423+
) :
424+
<></>
425+
}
421426
</>
422427
)}
423428
</TabPanel>

frontend/src/components/metadata/widgets/MetadataTextField.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export const MetadataTextField = (props) => {
3939
/>
4040
</Grid>
4141
<Grid item xs={1} sm={1} md={1} lg={1} xl={1}>
42-
{datasetRole.role !== undefined && datasetRole.role !== "viewer" ?
42+
{datasetRole !== undefined && datasetRole.role !== undefined && datasetRole.role !== "viewer" ?
4343
<MetadataEditButton readOnly={readOnly} setReadOnly={setReadOnly} updateMetadata={updateMetadata}
4444
content={localContent} metadataId={metadataId} resourceId={resourceId}
4545
widgetName={widgetName} setInputChanged={setInputChanged}

0 commit comments

Comments
 (0)