Skip to content

Commit c113f9b

Browse files
authored
use link instead of buttons (#1049)
1 parent 7f04f7a commit c113f9b

File tree

10 files changed

+50
-27
lines changed

10 files changed

+50
-27
lines changed

backend/app/routers/groups.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,8 @@ async def search_group(
9292

9393
criteria_list = [
9494
Or(
95-
RegEx(field=GroupDB.name, pattern=search_term),
96-
RegEx(field=GroupDB.description, pattern=search_term),
95+
RegEx(field=GroupDB.name, pattern=search_term, options="i"),
96+
RegEx(field=GroupDB.description, pattern=search_term, options="i"),
9797
),
9898
]
9999
if not admin or not admin_mode:

backend/app/routers/jobs.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,9 @@ async def get_all_job_summary(
5151
if listener_id is not None:
5252
filters.append(EventListenerJobViewList.listener_id == listener_id)
5353
if status is not None:
54-
filters.append(RegEx(field=EventListenerJobViewList.status, pattern=status))
54+
filters.append(
55+
RegEx(field=EventListenerJobViewList.status, pattern=status, options="i")
56+
)
5557
if created is not None:
5658
created_datetime_object = datetime.strptime(created, "%Y-%m-%d")
5759
filters.append(GTE(EventListenerJobViewList.created, created_datetime_object))

backend/app/routers/listeners.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,8 +229,8 @@ async def search_listeners(
229229
listeners_and_count = (
230230
await EventListenerDB.find(
231231
Or(
232-
RegEx(field=EventListenerDB.name, pattern=text),
233-
RegEx(field=EventListenerDB.description, pattern=text),
232+
RegEx(field=EventListenerDB.name, pattern=text, options="i"),
233+
RegEx(field=EventListenerDB.description, pattern=text, options="i"),
234234
),
235235
)
236236
.aggregate(aggregation_pipeline)

backend/app/routers/metadata.py

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,9 +138,17 @@ async def search_metadata_definition(
138138
mdds_and_count = (
139139
await MetadataDefinitionDB.find(
140140
Or(
141-
RegEx(field=MetadataDefinitionDB.name, pattern=search_term),
142-
RegEx(field=MetadataDefinitionDB.description, pattern=search_term),
143-
RegEx(field=MetadataDefinitionDB.context, pattern=search_term),
141+
RegEx(
142+
field=MetadataDefinitionDB.name, pattern=search_term, options="i"
143+
),
144+
RegEx(
145+
field=MetadataDefinitionDB.description,
146+
pattern=search_term,
147+
options="i",
148+
),
149+
RegEx(
150+
field=MetadataDefinitionDB.context, pattern=search_term, options="i"
151+
),
144152
),
145153
)
146154
.aggregate(

backend/app/routers/public_metadata.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,11 @@ async def search_metadata_definition(
6666

6767
mdds = await MetadataDefinitionDB.find(
6868
Or(
69-
RegEx(field=MetadataDefinitionDB.name, pattern=search_term),
70-
RegEx(field=MetadataDefinitionDB.description, pattern=search_term),
71-
RegEx(field=MetadataDefinitionDB.context, pattern=search_term),
69+
RegEx(field=MetadataDefinitionDB.name, pattern=search_term, options="i"),
70+
RegEx(
71+
field=MetadataDefinitionDB.description, pattern=search_term, options="i"
72+
),
73+
RegEx(field=MetadataDefinitionDB.context, pattern=search_term, options="i"),
7274
),
7375
sort=(-MetadataDefinitionDB.created),
7476
skip=skip,

backend/app/routers/users.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,9 @@ async def search_users(
118118
users_and_count = (
119119
await UserDB.find(
120120
Or(
121-
RegEx(field=UserDB.email, pattern=text),
122-
RegEx(field=UserDB.first_name, pattern=text),
123-
RegEx(field=UserDB.last_name, pattern=text),
121+
RegEx(field=UserDB.email, pattern=text, options="i"),
122+
RegEx(field=UserDB.first_name, pattern=text, options="i"),
123+
RegEx(field=UserDB.last_name, pattern=text, options="i"),
124124
)
125125
)
126126
.aggregate(
@@ -147,7 +147,7 @@ async def search_users_prefix(
147147
query_regx = f"^{prefix}.*"
148148
users_and_count = (
149149
await UserDB.find(
150-
Or(RegEx(field=UserDB.email, pattern=query_regx)),
150+
Or(RegEx(field=UserDB.email, pattern=query_regx, options="i")),
151151
)
152152
.aggregate(
153153
[_get_page_query(skip, limit, sort_field="email", ascending=True)],

frontend/src/components/groups/Groups.tsx

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import {
66
DialogContent,
77
DialogTitle,
88
Grid,
9+
Link as MuiLink,
910
Pagination,
1011
} from "@mui/material";
1112
import { RootState } from "../../types/data";
@@ -161,9 +162,13 @@ export function Groups() {
161162
}}
162163
>
163164
<TableCell scope="row" key={group.id}>
164-
<Button component={Link} to={`/groups/${group.id}`}>
165+
<MuiLink
166+
component={Link}
167+
to={`/groups/${group.id}`}
168+
sx={{ textDecoration: "none" }}
169+
>
165170
{group.name}
166-
</Button>
171+
</MuiLink>
167172
</TableCell>
168173
<TableCell scope="row" key={group.id} align="left">
169174
{group.description}

frontend/src/components/groups/MembersTableUserEntry.tsx

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import TableRow from "@mui/material/TableRow";
44
import TableCell from "@mui/material/TableCell";
55
import PersonIcon from "@mui/icons-material/Person";
66
import {
7-
Button,
87
ButtonGroup,
98
FormControl,
109
IconButton,
@@ -94,14 +93,18 @@ export function MembersTableUserEntry(props: MembersTableUserEntryProps) {
9493
height: "32px",
9594
borderRadius: "50%",
9695
verticalAlign: "middle",
96+
marginRight: "1em",
9797
}}
9898
/>
9999
) : (
100-
<PersonIcon sx={iconStyle} />
100+
<PersonIcon
101+
sx={{
102+
verticalAlign: "middle",
103+
marginRight: "1em",
104+
}}
105+
/>
101106
)}
102-
<Button>
103-
{member.user.first_name} {member.user.last_name}
104-
</Button>
107+
{member.user.first_name} {member.user.last_name}
105108
</TableCell>
106109
<TableCell align="right">{member.user.email}</TableCell>
107110
{member.user.email == creatorEmail && (

frontend/src/components/listeners/ListenerItem.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React from "react";
2-
import { Box, Button, IconButton, Tooltip, Typography } from "@mui/material";
2+
import { Box, IconButton, Link, Tooltip, Typography } from "@mui/material";
33
import { EventListenerOut } from "../../openapi/v2";
44
import { theme } from "../../theme";
55
import PlayCircleIcon from "@mui/icons-material/PlayCircle";
@@ -51,15 +51,16 @@ export default function ListenerItem(props: ListenerCardProps) {
5151
/>
5252
</Tooltip>
5353
)}
54-
<Button
54+
<Link
5555
onClick={() => {
5656
setOpenSubmitExtraction(true);
5757
setSelectedExtractor(extractor);
5858
setInfoOnly(true);
5959
}}
60+
sx={{ textDecoration: "none", cursor: "pointer" }}
6061
>
6162
{extractorName}
62-
</Button>
63+
</Link>
6364
{!(fileId !== undefined || datasetId !== undefined) ||
6465
!extractor["alive"] ? (
6566
<Typography

frontend/src/components/metadata/MetadataDefinitions.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import {
77
DialogTitle,
88
Grid,
99
IconButton,
10+
Link as MuiLink,
1011
Pagination,
1112
Snackbar,
1213
} from "@mui/material";
@@ -205,12 +206,13 @@ export function MetadataDefinitions() {
205206
}}
206207
>
207208
<TableCell scope="row" key={`${mdd.id}-name`}>
208-
<Button
209+
<MuiLink
209210
component={Link}
210211
to={`/metadata-definitions/${mdd.id}`}
212+
sx={{ textDecoration: "none" }}
211213
>
212214
{mdd.name}
213-
</Button>
215+
</MuiLink>
214216
</TableCell>
215217
<TableCell
216218
scope="row"

0 commit comments

Comments
 (0)