Skip to content

Commit cd1f9d8

Browse files
authored
make first name and last name required (#190)
1 parent 3cf45d9 commit cd1f9d8

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

backend/app/models/users.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111

1212
class UserBase(MongoModel):
1313
email: EmailStr
14-
first_name: Optional[str] = None
15-
last_name: Optional[str] = None
14+
first_name: str
15+
last_name: str
1616

1717

1818
class UserIn(UserBase):

scripts/develop/populate_fake_data.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
"last_name": fake.last_name(),
1717
}
1818
response = requests.post(f"{API_V2_STR}/users", json=user)
19+
if response.status_code != 200:
20+
raise ValueError(response.json())
1921
users.append(user)
2022
print(f"User created: {user}")
2123

@@ -32,5 +34,7 @@
3234
response = requests.post(
3335
f"{API_V2_STR}/datasets", json=dataset_data, headers=headers
3436
)
37+
if response.status_code != 200:
38+
raise ValueError(response.json())
3539
dataset_id = response.json().get("id")
3640
print(f"Dataset created: {dataset_id}")

0 commit comments

Comments
 (0)