Implement edit metadata definition (#977)

* initial draft

* fix react state mutation issue

* fix black formatting

* Added check not to edit definition if metadata exists and addressed feedbacks

Author: ddey2

backend/app/models/metadata.py

@@ -104,6 +104,7 @@ class MetadataDefinitionBase(BaseModel):
     ]  # https://json-ld.org/spec/latest/json-ld/#the-context
     context_url: Optional[str]  # single URL applying to contents
     fields: List[MetadataField]
+    modified: datetime = Field(default_factory=datetime.utcnow)
 
     # TODO: Space-level requirements?
 

backend/app/routers/metadata.py

@@ -1,3 +1,4 @@
+import datetime
 from typing import Optional
 
 from app import dependencies
@@ -70,6 +71,62 @@ async def get_metadata_definition_list(
     return page.dict()
 
 
+@router.put(
+    "/definition/{metadata_definition_id}", response_model=MetadataDefinitionOut
+)
+async def update_metadata_definition(
+    metadata_definition: MetadataDefinitionIn,
+    metadata_definition_id: str,
+    user=Depends(get_current_user),
+):
+    existing_count = await MetadataDefinitionDB.find(
+        {
+            "$and": [
+                {"_id": {"$ne": PydanticObjectId(metadata_definition_id)}},
+                {"name": {"$eq": metadata_definition.name}},
+            ]
+        }
+    ).count()
+    if existing_count > 0:
+        raise HTTPException(
+            status_code=409,
+            detail=f"Metadata definition named {metadata_definition.name} already exists.",
+        )
+    else:
+        if (
+            mdd := await MetadataDefinitionDB.get(
+                PydanticObjectId(metadata_definition_id)
+            )
+        ) is not None:
+            # Check if metadata using this definition exists
+            metadata_using_definition = await MetadataDB.find(
+                MetadataDB.definition == mdd.name
+            ).to_list()
+
+            if len(metadata_using_definition) > 0:
+                raise HTTPException(
+                    status_code=400,
+                    detail=f"Metadata definition: {mdd.name} ({metadata_definition_id}) in use. "
+                    f"You cannot edit it if there are existing metadata using this definition.",
+                )
+            try:
+                metadata_update = metadata_definition.dict()
+                metadata_update["modified"] = datetime.datetime.utcnow()
+
+                # Update mdd's attributes using the updated dictionary
+                for key, value in metadata_update.items():
+                    setattr(mdd, key, value)
+                await mdd.save()
+                return mdd.dict()
+            except Exception as e:
+                raise HTTPException(status_code=500, detail=e.args[0])
+        else:
+            raise HTTPException(
+                status_code=404,
+                detail=f"Metadata definition id {metadata_definition_id} not found",
+            )
+
+
 @router.get(
     "/definition/{metadata_definition_id}", response_model=MetadataDefinitionOut
 )

frontend/src/actions/metadata.js

@@ -97,6 +97,29 @@ export function postMetadataDefinition(metadataDefinition) {
 	};
 }
 
+export const EDIT_METADATA_DEFINITION = "EDIT_METADATA_DEFINITION";
+
+export function updateMetadataDefinition(id, metadataDefinition) {
+	return (dispatch) => {
+		return V2.MetadataService.updateMetadataDefinitionApiV2MetadataDefinitionMetadataDefinitionIdPut(
+			id,
+			metadataDefinition
+		)
+			.then((json) => {
+				dispatch({
+					type: EDIT_METADATA_DEFINITION,
+					metadataDefinition: json,
+					receivedAt: Date.now(),
+				});
+			})
+			.catch((reason) => {
+				dispatch(
+					handleErrors(reason, updateMetadataDefinition(id, metadataDefinition))
+				);
+			});
+	};
+}
+
 export const RESET_SAVE_METADATA_DEFINITIONS =
 	"RESET_SAVE_METADATA_DEFINITIONS";