Skip to content

Commit 4489c7a

Browse files
authored
Merge pull request #16 from clowder-framework/fix-status-bug
Fix status bug
2 parents cac8426 + 8105160 commit 4489c7a

File tree

4 files changed

+19
-8
lines changed

4 files changed

+19
-8
lines changed

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,17 @@ All notable changes to this project will be documented in this file.
44
The format is based on [Keep a Changelog](http://keepachangelog.com/)
55
and this project adheres to [Semantic Versioning](http://semver.org/).
66

7+
## 2.3.1 - 2020-09-18
8+
9+
With this version we no longer gurantee support for versions of python below 3.
10+
11+
### Fixed
12+
- There was an issue where status messages could cause an exception. This would prevent most extractors from running correctly.
13+
714
## 2.3.0 - 2020-09-15
815

16+
**CRITICAL BUG IN THIS VERSION. PLEASE USE VERSION 2.3.1**
17+
918
Removed develop branch, all pull requests will need to be against master from now
1019
forward. Please update version number in setup.py in each PR.
1120

pyclowder/connectors.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ def _process_message(self, body):
391391
self.register_extractor("%s?key=%s" % (url, secret_key))
392392

393393
# tell everybody we are starting to process the file
394-
self.status_update(pyclowder.utils.StatusMessage.start.value, resource, "Started processing.")
394+
self.status_update(pyclowder.utils.StatusMessage.start, resource, "Started processing.")
395395

396396
# checks whether to process the file in this message or not
397397
# pylint: disable=too-many-nested-blocks
@@ -455,7 +455,7 @@ def _process_message(self, body):
455455
logger.exception("Error removing temporary dataset directory")
456456

457457
else:
458-
self.status_update(pyclowder.utils.StatusMessage.skip.value, resource, "Skipped in check_message")
458+
self.status_update(pyclowder.utils.StatusMessage.skip, resource, "Skipped in check_message")
459459

460460
self.message_ok(resource)
461461

@@ -534,16 +534,16 @@ def status_update(self, status, resource, message):
534534
logging.getLogger(__name__).info("[%s] : %s: %s", resource["id"], status, message)
535535

536536
def message_ok(self, resource, message="Done processing."):
537-
self.status_update(pyclowder.utils.StatusMessage.done.value, resource, message)
537+
self.status_update(pyclowder.utils.StatusMessage.done, resource, message)
538538

539539
def message_error(self, resource, message="Error processing message."):
540-
self.status_update(pyclowder.utils.StatusMessage.error.value, resource, message)
540+
self.status_update(pyclowder.utils.StatusMessage.error, resource, message)
541541

542542
def message_resubmit(self, resource, retry_count, message="Resubmitting message."):
543-
self.status_update(pyclowder.utils.StatusMessage.retry.value, resource, message)
543+
self.status_update(pyclowder.utils.StatusMessage.retry, resource, message)
544544

545545
def message_process(self, resource, message):
546-
self.status_update(pyclowder.utils.StatusMessage.processing.value, resource, message)
546+
self.status_update(pyclowder.utils.StatusMessage.processing, resource, message)
547547

548548
def get(self, url, params=None, raise_status=True, **kwargs):
549549
"""
@@ -938,7 +938,7 @@ def status_update(self, status, resource, message):
938938
"job_id": self.job_id,
939939
"status": "%s: %s" % (status, message),
940940
"start": pyclowder.utils.iso8601time(),
941-
"message_type": status,
941+
"message_type": "%s" % status,
942942
"message": message
943943
}})
944944

requirements.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
enum34==1.1.6
12
pika==1.1.0
23
PyYAML==5.1
34
requests==2.24.0

setup.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ def description():
99

1010

1111
setup(name='pyclowder',
12-
version='2.3.0',
12+
version='2.3.1',
1313
packages=find_packages(),
1414
description='Python SDK for the Clowder Data Management System',
1515
long_description=description(),
@@ -32,6 +32,7 @@ def description():
3232
keywords=['clowder', 'data management system'],
3333

3434
install_requires=[
35+
'enum34==1.1.6',
3536
'pika==1.1.0',
3637
'PyYAML==5.1',
3738
'requests==2.24.0',

0 commit comments

Comments
 (0)