Skip to content

Commit af47973

Browse files
committed
Update test environment to fix tests on legacy PHP 7.2 with PHPUnit 8.5
1 parent a07c446 commit af47973

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,7 @@ jobs:
4343
- run: composer install
4444
- run: docker run -d --name mysql --net=host -e MYSQL_RANDOM_ROOT_PASSWORD=yes -e MYSQL_DATABASE=test -e MYSQL_USER=test -e MYSQL_PASSWORD=test ${{ matrix.rdbms }}
4545
- run: bash tests/wait-for-mysql.sh
46-
- run: vendor/bin/phpunit --coverage-text
47-
if: ${{ matrix.php >= 7.3 }}
48-
- run: vendor/bin/phpunit --coverage-text -c phpunit.xml.legacy
49-
if: ${{ matrix.php < 7.3 }}
46+
- run: vendor/bin/phpunit --coverage-text ${{ matrix.php < 7.3 && '-c phpunit.xml.legacy' || '' }}
5047

5148
PHPUnit-hhvm:
5249
name: PHPUnit (HHVM)

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"react/socket": "^1.16"
1414
},
1515
"require-dev": {
16-
"phpunit/phpunit": "^9.6 || ^5.7 || ^4.8.36",
16+
"phpunit/phpunit": "^9.6 || ^8.5 || ^5.7 || ^4.8.36",
1717
"react/async": "^4.3 || ^3 || ^2"
1818
},
1919
"autoload": {

0 commit comments

Comments
 (0)