Support ?password and ?db URI query parameters

Author: clue

README.md

@@ -137,7 +137,9 @@ authentication mechanism does not employ a username, so you can pass the
 password "secret" as part of the URI like this:
 
 ```php
+// both forms are equivalent
 $factory->createClient('redis://ignored:secret@localhost');
+$factory->createClient('redis://localhost?password=secret');
 ```
 
 > Legacy notice: The `redis://` scheme is defined and preferred as of `v1.2.0`.
@@ -149,7 +151,9 @@ $factory->createClient('redis://ignored:secret@localhost');
 You can optionally include a path that will be used to select (SELECT command) the right database:
 
 ```php
+// both forms are equivalent
 $factory->createClient('redis://localhost/2');
+$factory->createClient('redis://localhost?db=2');
 ```
 
 You can use the [standard](https://www.iana.org/assignments/uri-schemes/prov/rediss)

src/Factory.php

@@ -141,6 +141,19 @@ private function parseUrl($target)
             $parts['host'] = 'tls://' . $parts['host'];
         }
 
+        if (isset($parts['query'])) {
+            $args = array();
+            parse_str($parts['query'], $args);
+
+            if (isset($args['password'])) {
+                $parts['auth'] = $args['password'];
+            }
+
+            if (isset($args['db'])) {
+                $parts['db'] = $args['db'];
+            }
+        }
+
         unset($parts['scheme'], $parts['user'], $parts['pass'], $parts['path']);
 
         return $parts;

tests/FactoryTest.php

@@ -68,6 +68,15 @@ public function testWillWriteSelectCommandIfTargetContainsPath()
         $this->factory->createClient('redis://127.0.0.1/demo');
     }
 
+    public function testWillWriteSelectCommandIfTargetContainsDbQueryParameter()
+    {
+        $stream = $this->getMockBuilder('React\Socket\ConnectionInterface')->getMock();
+        $stream->expects($this->once())->method('write')->with("*2\r\n$6\r\nselect\r\n$1\r\n4\r\n");
+
+        $this->connector->expects($this->once())->method('connect')->willReturn(Promise\resolve($stream));
+        $this->factory->createClient('redis://127.0.0.1?db=4');
+    }
+
     public function testWillWriteAuthCommandIfRedisUriContainsUserInfo()
     {
         $stream = $this->getMockBuilder('React\Socket\ConnectionInterface')->getMock();
@@ -77,6 +86,15 @@ public function testWillWriteAuthCommandIfRedisUriContainsUserInfo()
         $this->factory->createClient('redis://hello:[email protected]');
     }
 
+    public function testWillWriteAuthCommandIfTargetContainsPasswordQueryParameter()
+    {
+        $stream = $this->getMockBuilder('React\Socket\ConnectionInterface')->getMock();
+        $stream->expects($this->once())->method('write')->with("*2\r\n$4\r\nauth\r\n$6\r\nsecret\r\n");
+
+        $this->connector->expects($this->once())->method('connect')->with('example.com:6379')->willReturn(Promise\resolve($stream));
+        $this->factory->createClient('redis://example.com?password=secret');
+    }
+
     public function testWillWriteAuthCommandIfRedissUriContainsUserInfo()
     {
         $stream = $this->getMockBuilder('React\Socket\ConnectionInterface')->getMock();