Refactor tests into reusable components

Author: clue

tests/FactoryTest.php

@@ -10,36 +10,47 @@ class FactoryTest extends PHPUnit_Framework_TestCase
 {
     private $factory;
 
-    public function testClientSuccess()
+    public function setUp()
     {
-        $loop = React\EventLoop\Factory::create();
-        $factory = new Datagram\Factory($loop, $this->createResolverMock());
+        $this->loop = React\EventLoop\Factory::create();
+        $this->factory = new Datagram\Factory($this->loop, $this->createResolverMock());
+    }
+
+    public function testCreateClient()
+    {
+        $promise = $this->factory->createClient('127.0.0.1', 12345);
+
+        $capturedClient = $this->getValueFromResolvedPromise($promise);
+        $this->assertInstanceOf('Datagram\Socket', $capturedClient);
+
+        $capturedClient->close();
+    }
 
-        $promise = $factory->createClient('127.0.0.1', 12345);
+    protected function getValueFromResolvedPromise($promise)
+    {
         $this->assertInstanceOf('React\Promise\PromiseInterface', $promise);
 
-        $capturedClient = null;
-        $promise->then(function ($client) use (&$capturedClient, $loop) {
-            $capturedClient = $client;
+        $loop = $this->loop;
+        $capturedValue = null;
+        $promise->then(function ($value) use (&$capturedValue, $loop) {
+            $capturedValue = $value;
             $loop->stop();
         }, $this->expectCallableNever());
 
-        // future-turn resolutions are not enforced, so the client MAY be known here already
-        if ($capturedClient === null) {
+        // future-turn resolutions are not enforced, so the value MAY be known here already
+        if ($capturedValue === null) {
             $loop->run();
         }
 
-        $this->assertInstanceOf('Datagram\Socket', $capturedClient);
-
-        $capturedClient->close();
+        return $capturedValue;
     }
 
     protected function expectCallableOnce()
     {
         $mock = $this->createCallableMock();
         $mock
-        ->expects($this->once())
-        ->method('__invoke');
+            ->expects($this->once())
+            ->method('__invoke');
 
         return $mock;
     }
@@ -48,8 +59,8 @@ protected function expectCallableNever()
     {
         $mock = $this->createCallableMock();
         $mock
-        ->expects($this->never())
-        ->method('__invoke');
+            ->expects($this->never())
+            ->method('__invoke');
 
         return $mock;
     }