Skip to content

[FEATURE] Add symfony v7 support #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maikschneider wants to merge 2 commits into
base: 1.x
Choose a base branch
from
Open

[FEATURE] Add symfony v7 support #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
409d2cf
feat: set minimum php version to 7.0.33, adjust build script
maikschneider Sep 21, 2024
9309a72
feat: allow symfony packages of version 7, drop 2.5 support
maikschneider Sep 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions bin/build.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,11 @@
rm -rf build && mkdir build &&
cp -r bin/ src/ composer.json LICENSE build/ && rm build/bin/build.php build/src/Box/Extract.php &&
sed -i \'s/@dev/' . $version .'/g\' build/src/App.php &&
composer config -d build/ platform.php 5.3.6 &&
composer config -d build/ platform.php 7.0.33 &&
composer install -d build/ --no-dev &&

cd build/vendor && rm -rf */*/tests/ */*/src/tests/ */*/docs/ */*/*.md */*/composer.* */*/phpunit.* */*/.gitignore */*/.*.yml */*/*.xml && cd - >/dev/null &&
cd build/vendor/symfony/ && rm -rf */Symfony/Component/*/Tests/ */Symfony/Component/*/*.md */Symfony/Component/*/composer.* */Symfony/Component/*/phpunit.* */Symfony/Component/*/.gitignore && cd ->/dev/null &&
cd build/vendor/guzzle/guzzle && rm -r phar-stub.php phing/ && cd ->/dev/null &&
build/bin/phar-composer build build/ ' . escapeshellarg($out) . ' &&

echo -n "Reported version is: " && php ' . escapeshellarg($out) . ' --version', $code);
Expand Down
8 changes: 4 additions & 4 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@
}
],
"require": {
"php": ">=5.3.6",
"php": ">=7.0.33",
"knplabs/packagist-api": "^1.0",
"symfony/console": "^6.0 || ^5.0 || ^4.0 || ^3.0 || ^2.5",
"symfony/finder": "^6.0 || ^5.0 || ^4.0 || ^3.0 || ^2.5",
"symfony/process": "^6.0 || ^5.0 || ^4.0 || ^3.0 || ^2.5"
"symfony/console": "^7.0 || ^6.0 || ^5.0 || ^4.0 || ^3.0",
"symfony/finder": "^7.0 || ^6.0 || ^5.0 || ^4.0 || ^3.0",
"symfony/process": "^7.0 || ^6.0 || ^5.0 || ^4.0 || ^3.0"
},
"require-dev": {
"phpunit/phpunit": "^9.5 || ^5.7 || ^4.8.36"
Expand Down
2 changes: 1 addition & 1 deletion src/Command/Build.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ protected function configure()
->addArgument('target', InputArgument::OPTIONAL, 'Path to write phar output to (defaults to project name)');
}

protected function execute(InputInterface $input, OutputInterface $output)
protected function execute(InputInterface $input, OutputInterface $output): int
{
$this->packager->setOutput($output);
$this->packager->coerceWritable();
Expand Down
2 changes: 1 addition & 1 deletion src/Command/Install.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ protected function configure()
->addArgument('target', InputArgument::OPTIONAL, 'Path to install to', '/usr/local/bin');
}

protected function execute(InputInterface $input, OutputInterface $output)
protected function execute(InputInterface $input, OutputInterface $output): int
{
if ($this->isWindows) {
$output->writeln('<error>Command not available on this platform. Please use the "build" command and place Phar in your $PATH manually.</error>');
Expand Down
2 changes: 1 addition & 1 deletion src/Command/Search.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ protected function select(InputInterface $input, OutputInterface $output, $label
return $indices[$index - 1];
}

protected function execute(InputInterface $input, OutputInterface $output)
protected function execute(InputInterface $input, OutputInterface $output): int
{
$this->packager->setOutput($output);
$this->packager->coerceWritable();
Expand Down