Skip to content

Commit d9cefea

Browse files
authored
Merge pull request #35 from clue-labs/phpunit8
Update test environment to fix tests on legacy PHP 7.2 with PHPUnit 8.5
2 parents 104be46 + 95dddd5 commit d9cefea

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,7 @@ jobs:
3131
php-version: ${{ matrix.php }}
3232
coverage: xdebug
3333
- run: composer install
34-
- run: vendor/bin/phpunit --coverage-text
35-
if: ${{ matrix.php >= 7.3 }}
36-
- run: vendor/bin/phpunit --coverage-text -c phpunit.xml.legacy
37-
if: ${{ matrix.php < 7.3 }}
34+
- run: vendor/bin/phpunit --coverage-text ${{ matrix.php < 7.3 && '-c phpunit.xml.legacy' || '' }}
3835

3936
PHPUnit-hhvm:
4037
name: PHPUnit (HHVM)

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"react/stream": "^1.2"
1616
},
1717
"require-dev": {
18-
"phpunit/phpunit": "^9.6 || ^5.7 || ^4.8.36",
18+
"phpunit/phpunit": "^9.6 || ^8.5 || ^5.7 || ^4.8.36",
1919
"react/child-process": "^0.6.3",
2020
"react/event-loop": "^1.2"
2121
},

0 commit comments

Comments
 (0)