Merge pull request #80 from clue-labs/update-tests

Update test suite and report failed assertions

Author: SimonFrings

.github/workflows/ci.yml

@@ -6,7 +6,8 @@ on:
 
 jobs:
   PHPUnit:
-    runs-on: ubuntu-20.04
+    name: PHPUnit (PHP ${{ matrix.php }})
+    runs-on: ubuntu-22.04
     strategy:
       matrix:
         php:
@@ -23,12 +24,12 @@ jobs:
           - 5.4
           - 5.3
     steps:
-      - uses: actions/checkout@v2
-      - name: Setup PHP
-        uses: shivammathur/setup-php@v2
+      - uses: actions/checkout@v3
+      - uses: shivammathur/setup-php@v2
         with:
           php-version: ${{ matrix.php }}
           coverage: xdebug
+          ini-file: development
       - run: composer install
       - run: vendor/bin/phpunit --coverage-text
         if: ${{ matrix.php >= 7.3 }}

composer.json

@@ -10,12 +10,6 @@
             "email": "[email protected]"
         }
     ],
-    "autoload": {
-        "psr-4": { "Clue\\React\\Docker\\": "src/" }
-    },
-    "autoload-dev": {
-        "psr-4": { "Clue\\Tests\\React\\Docker\\": "tests/" }
-    },
     "require": {
         "php": ">=5.3",
         "clue/json-stream": "^0.1",
@@ -28,9 +22,19 @@
         "rize/uri-template": "^0.3"
     },
     "require-dev": {
-        "react/async": "^4 || ^3 || ^2",
         "clue/caret-notation": "^0.2",
         "clue/tar-react": "^0.2",
-        "phpunit/phpunit": "^9.3 || ^5.7 || ^4.8.35"
+        "phpunit/phpunit": "^9.5 || ^5.7 || ^4.8.35",
+        "react/async": "^4 || ^3 || ^2"
+    },
+    "autoload": {
+        "psr-4": {
+            "Clue\\React\\Docker\\": "src/"
+        }
+    },
+    "autoload-dev": {
+        "psr-4": {
+            "Clue\\Tests\\React\\Docker\\": "tests/"
+        }
     }
 }

phpunit.xml.dist

@@ -1,11 +1,12 @@
 <?xml version="1.0" encoding="UTF-8"?>
 
-<!-- PHPUnit configuration file with new format for PHPUnit 9.3+ -->
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
-         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd"
+<!-- PHPUnit configuration file with new format for PHPUnit 9.5+ -->
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.5/phpunit.xsd"
          bootstrap="vendor/autoload.php"
+         cacheResult="false"
          colors="true"
-         cacheResult="false">
+         convertDeprecationsToExceptions="true">
     <testsuites>
         <testsuite name="Docker React Test Suite">
             <directory>./tests/</directory>
@@ -16,4 +17,12 @@
             <directory>./src/</directory>
         </include>
     </coverage>
+    <php>
+        <ini name="error_reporting" value="-1" />
+        <!-- Evaluate assertions, requires running with "php -d zend.assertions=1 vendor/bin/phpunit" -->
+        <!-- <ini name="zend.assertions" value="1" /> -->
+        <ini name="assert.active" value="1" />
+        <ini name="assert.exception" value="1" />
+        <ini name="assert.bail" value="0" />
+    </php>
 </phpunit>

phpunit.xml.legacy

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 
-<!-- PHPUnit configuration file with old format for PHPUnit 9.2 or older -->
+<!-- PHPUnit configuration file with old format for legacy PHPUnit -->
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/4.8/phpunit.xsd"
          bootstrap="vendor/autoload.php"
@@ -15,4 +15,12 @@
             <directory>./src/</directory>
         </whitelist>
     </filter>
+    <php>
+        <ini name="error_reporting" value="-1" />
+        <!-- Evaluate assertions, requires running with "php -d zend.assertions=1 vendor/bin/phpunit" -->
+        <!-- <ini name="zend.assertions" value="1" /> -->
+        <ini name="assert.active" value="1" />
+        <ini name="assert.exception" value="1" />
+        <ini name="assert.bail" value="0" />
+    </php>
 </phpunit>

tests/FunctionalClientTest.php

@@ -91,13 +91,21 @@ public function testCreateStartAndRemoveContainer()
         $promise = $this->client->events($start, $end, array('container' => array($container['Id'])));
         $ret = \React\Async\await($promise);
 
-        // expects "start", "attach", "kill", "die", "destroy" events
-        $this->assertEquals(5, count($ret));
-        $this->assertEquals('start', $ret[0]['status']);
-        $this->assertEquals('attach', $ret[1]['status']);
-        $this->assertEquals('kill', $ret[2]['status']);
-        $this->assertEquals('die', $ret[3]['status']);
-        $this->assertEquals('destroy', $ret[4]['status']);
+        $this->assertIsArray($ret);
+
+        $status = array(); // array_column($ret, 'status'); // PHP 5.5+
+        foreach ($ret as $one) {
+            $status[] = $one['status'];
+        }
+
+        // expect 4 events as of ~2021, 5 in earlier versions
+        if (count($status) === 4) {
+            // start, die, attach, destroy
+            $this->assertEquals(array('start', 'die', 'attach', 'destroy'), $status);
+        } else {
+            // expects "start", "attach", "kill", "die", "destroy" events
+            $this->assertEquals(array('start', 'attach', 'kill', 'die', 'destroy'), $status);
+        }
     }
 
     /**