Skip to content

Commit 9340132

Browse files
authored
Merge pull request #82 from clue-labs/unhandled-rejections
Update test suite to avoid unhandled promise rejections
2 parents 0ecc37a + 2e8e342 commit 9340132

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"react/event-loop": "^1.2",
1717
"react/http": "^1.8",
1818
"react/promise": "^3 || ^2.0 || ^1.1",
19-
"react/promise-stream": "^1.4",
19+
"react/promise-stream": "^1.6",
2020
"react/socket": "^1.12",
2121
"react/stream": "^1.2",
2222
"rize/uri-template": "^0.3"

tests/IntegrationTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
use Clue\React\Docker\Client;
66
use Psr\Http\Message\ServerRequestInterface;
7+
use React\Http\Message\Response;
78
use React\Promise\Deferred;
89

910
class IntegrationTest extends TestCase
@@ -26,6 +27,7 @@ public function testPingCtorWithExplicitUnixUrlSendsRequestToGivenUnixSocket()
2627
$deferred = new Deferred();
2728
$http = new \React\Http\HttpServer(function (ServerRequestInterface $request) use ($deferred) {
2829
$deferred->resolve($request->getRequestTarget());
30+
return Response::plaintext('OK');
2931
});
3032

3133
$http->listen($socket);
@@ -46,6 +48,7 @@ public function testPingCtorWithExplicitHttpUrlSendsRequestToGivenHttpUrlWithBas
4648
$deferred = new Deferred();
4749
$http = new \React\Http\HttpServer(function (ServerRequestInterface $request) use ($deferred) {
4850
$deferred->resolve($request->getRequestTarget());
51+
return Response::plaintext('OK');
4952
});
5053

5154
$socket = new \React\Socket\SocketServer('127.0.0.1:0');

0 commit comments

Comments
 (0)