Improve error reporting for invalid responses by using ResponseException

Author: clue

README.md

@@ -193,14 +193,17 @@ The `error` event will be emitted when the EventSource connection fails.
 The event receives a single `Exception` argument for the error instance.
 
 ```php
-$redis->on('error', function (Exception $e) {
+$es->on('error', function (Exception $e) {
     echo 'Error: ' . $e->getMessage() . PHP_EOL;
 });
 ```
 
 The EventSource connection will be retried automatically when it is temporarily
 disconnected. If the server sends a non-successful HTTP status code or an
 invalid `Content-Type` response header, the connection will fail permanently.
+In this case, the `error` event will receive a
+[`ResponseException`](https://github.com/reactphp/http#responseexception)
+that provides access to the response via the `getResponse()` method.
 
 ```php
 $es->on('error', function (Exception $e) use ($es) {

src/EventSource.php

@@ -7,6 +7,7 @@
 use React\EventLoop\Loop;
 use React\EventLoop\LoopInterface;
 use React\Http\Browser;
+use React\Http\Message\ResponseException;
 use React\Stream\ReadableStreamInterface;
 
 /**
@@ -193,7 +194,8 @@ private function request()
         $this->request->then(function (ResponseInterface $response) {
             if ($response->getStatusCode() !== 200) {
                 $this->readyState = self::CLOSED;
-                $this->emit('error', [new \UnexpectedValueException(
+                $this->emit('error', [new ResponseException(
+                    $response,
                     'Expected "200 OK" response status, ' . $this->quote($response->getStatusCode() . ' ' . $response->getReasonPhrase()) . ' response status returned'
                 )]);
                 $this->close();
@@ -204,7 +206,8 @@ private function request()
             $contentType = $response->getHeaderLine('Content-Type');
             if (!preg_match('/^text\/event-stream(?:$|;)/i', $contentType)) {
                 $this->readyState = self::CLOSED;
-                $this->emit('error', [new \UnexpectedValueException(
+                $this->emit('error', [new ResponseException(
+                    $response,
                     'Expected "Content-Type: text/event-stream" response header, ' . (!$response->hasHeader('Content-Type') ? 'no "Content-Type"' : $this->quote('Content-Type: ' . $contentType)) . ' response header returned'
                 )]);
                 $this->close();

tests/EventSourceTest.php

@@ -268,8 +268,10 @@ public function testConstructorWillReportFatalErrorWhenGetResponseResolvesWithIn
         $deferred->resolve($response);
 
         $this->assertEquals(EventSource::CLOSED, $readyState);
-        $this->assertInstanceOf('UnexpectedValueException', $caught);
+        $this->assertInstanceOf('React\Http\Message\ResponseException', $caught);
         $this->assertEquals($expectedMessage, $caught->getMessage());
+        $this->assertEquals($response->getStatusCode(), $caught->getCode());
+        $this->assertSame($response, $caught->getResponse());
     }
 
     public function provideInvalidContentType()
@@ -320,8 +322,9 @@ public function testConstructorWillReportFatalErrorWhenGetResponseResolvesWithIn
         $deferred->resolve($response);
 
         $this->assertEquals(EventSource::CLOSED, $readyState);
-        $this->assertInstanceOf('UnexpectedValueException', $caught);
+        $this->assertInstanceOf('React\Http\Message\ResponseException', $caught);
         $this->assertEquals($expectedMessage, $caught->getMessage());
+        $this->assertSame($response, $caught->getResponse());
     }
 
     public function testConstructorWillReportOpenWhenGetResponseResolvesWithValidResponse()