Skip to content

Commit e4b9b46

Browse files
authored
Merge pull request #26 from clue-labs/default-loop
Simplify examples by updating to new default loop
2 parents 9b403da + 81c0a94 commit e4b9b46

File tree

4 files changed

+22
-27
lines changed

4 files changed

+22
-27
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ as parsed values instead of just chunks of strings:
134134
```
135135

136136
```php
137-
$stdin = new ReadableResourceStream(STDIN, $loop);
137+
$stdin = new ReadableResourceStream(STDIN);
138138

139139
$stream = new Decoder($stdin);
140140

@@ -234,7 +234,7 @@ and accepts its data through the same interface, but handles any data as complet
234234
JSON elements instead of just chunks of strings:
235235

236236
```php
237-
$stdout = new WritableResourceStream(STDOUT, $loop);
237+
$stdout = new WritableResourceStream(STDOUT);
238238

239239
$stream = new Encoder($stdout);
240240

composer.json

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,18 @@
1010
"email": "[email protected]"
1111
}
1212
],
13-
"autoload": {
14-
"psr-4": { "Clue\\React\\NDJson\\": "src/" }
15-
},
16-
"autoload-dev": {
17-
"psr-4": { "Clue\\Tests\\React\\NDJson\\": "tests/" }
18-
},
1913
"require": {
2014
"php": ">=5.3",
21-
"react/stream": "^1.0 || ^0.7 || ^0.6"
15+
"react/stream": "^1.2"
2216
},
2317
"require-dev": {
24-
"react/event-loop": "^1.0 || ^0.5 || ^0.4 || ^0.3",
18+
"react/event-loop": "^1.2",
2519
"phpunit/phpunit": "^9.3 || ^5.7 || ^4.8.35"
20+
},
21+
"autoload": {
22+
"psr-4": { "Clue\\React\\NDJson\\": "src/" }
23+
},
24+
"autoload-dev": {
25+
"psr-4": { "Clue\\Tests\\React\\NDJson\\": "tests/" }
2626
}
2727
}

examples/91-benchmark-count.php

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
// $ php examples/91-benchmark-count.php < title.ratings.ndjson
1616

1717
use Clue\React\NDJson\Decoder;
18-
use React\EventLoop\Factory;
18+
use React\EventLoop\Loop;
1919
use React\Stream\ReadableResourceStream;
2020

2121
require __DIR__ . '/../vendor/autoload.php';
@@ -24,24 +24,21 @@
2424
echo 'NOTICE: The "xdebug" extension is loaded, this has a major impact on performance.' . PHP_EOL;
2525
}
2626

27-
$loop = Factory::create();
28-
$decoder = new Decoder(new ReadableResourceStream(STDIN, $loop), true);
27+
$decoder = new Decoder(new ReadableResourceStream(STDIN), true);
2928

3029
$count = 0;
3130
$decoder->on('data', function () use (&$count) {
3231
++$count;
3332
});
3433

3534
$start = microtime(true);
36-
$report = $loop->addPeriodicTimer(0.05, function () use (&$count, $start) {
35+
$report = Loop::addPeriodicTimer(0.05, function () use (&$count, $start) {
3736
printf("\r%d records in %0.3fs...", $count, microtime(true) - $start);
3837
});
3938

40-
$decoder->on('close', function () use (&$count, $report, $loop, $start) {
39+
$decoder->on('close', function () use (&$count, $report, $start) {
4140
$now = microtime(true);
42-
$loop->cancelTimer($report);
41+
Loop::cancelTimer($report);
4342

4443
printf("\r%d records in %0.3fs => %d records/s\n", $count, $now - $start, $count / ($now - $start));
4544
});
46-
47-
$loop->run();

examples/validate.php

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,18 @@
22

33
// $ php examples/validate.php < examples/users.ndjson
44

5-
use React\EventLoop\Factory;
6-
use React\Stream\ReadableResourceStream;
7-
use React\Stream\WritableResourceStream;
85
use Clue\React\NDJson\Decoder;
96
use Clue\React\NDJson\Encoder;
7+
use React\EventLoop\Loop;
8+
use React\Stream\ReadableResourceStream;
9+
use React\Stream\WritableResourceStream;
1010

1111
require __DIR__ . '/../vendor/autoload.php';
1212

13-
$loop = Factory::create();
14-
1513
$exit = 0;
16-
$in = new ReadableResourceStream(STDIN, $loop);
17-
$out = new WritableResourceStream(STDOUT, $loop);
18-
$info = new WritableResourceStream(STDERR, $loop);
14+
$in = new ReadableResourceStream(STDIN);
15+
$out = new WritableResourceStream(STDOUT);
16+
$info = new WritableResourceStream(STDERR);
1917

2018
$decoder = new Decoder($in);
2119
$encoder = new Encoder($out);
@@ -30,6 +28,6 @@
3028
$info->write('Valid NDJson will be forwarded to STDOUT' . PHP_EOL);
3129
$info->write('Invalid NDJson will raise an error on STDERR and exit with code 1' . PHP_EOL);
3230

33-
$loop->run();
31+
Loop::run();
3432

3533
exit($exit);

0 commit comments

Comments
 (0)