Merge pull request #24 from clue-labs/tests

Forward compatibility with PHP 7.1 and PHPUnit v5

Author: clue

.travis.yml

@@ -5,7 +5,8 @@ php:
   - 5.4
   - 5.5
   - 5.6
-  - 7
+  - 7.0
+  - 7.1
   - hhvm # ignore errors, see below
 
 # lock distro so new future defaults will not break the build

README.md

@@ -151,10 +151,17 @@ See also the [CHANGELOG](CHANGELOG.md) for details about version upgrades.
 
 ## Tests
 
-In order to run the tests, you need PHPUnit:
+To run the test suite, you first need to clone this repo and then install all
+dependencies [through Composer](http://getcomposer.org):
 
 ```bash
-$ phpunit
+$ composer install
+```
+
+To run the test suite, go to the project root and run:
+
+```bash
+$ php vendor/bin/phpunit
 ```
 
 The test suite contains both unit tests and functional integration tests.

composer.json

@@ -17,13 +17,13 @@
     	"php": ">=5.3",
         "react/event-loop": "~0.4.0|~0.3.0",
         "react/socket-client": "^0.5 || ^0.4 || ^0.3",
-        "react/dns": "~0.4.0|~0.3.0",
+        "react/dns": "^0.4.1 || ^0.3",
         "react/promise": "~2.0|~1.1",
         "react/stream": "^0.4.2",
         "clue/qdatastream": "^0.6"
     },
     "require-dev": {
         "clue/block-react": "^1.1",
-        "phpunit/phpunit": "^4.8"
+        "phpunit/phpunit": "^5.0 || ^4.8"
     }
 }

tests/ClientTest.php

@@ -18,7 +18,7 @@ public function setUp()
 
     public function testCtorOptionalArgs()
     {
-        $this->stream = $this->getMock('React\Stream\DuplexStreamInterface');
+        $this->stream = $this->getMockBuilder('React\Stream\DuplexStreamInterface')->getMock();
         new Client($this->stream);
     }
 
@@ -54,7 +54,7 @@ public function testPauseWillPauseUnderlyingStream()
 
     public function testPipeWillReturnDestStream()
     {
-        $dest = $this->getMock('React\Stream\WritableStreamInterface');
+        $dest = $this->getMockBuilder('React\Stream\WritableStreamInterface')->getMock();
 
         $this->assertEquals($dest, $this->client->pipe($dest));
     }

tests/FactoryTest.php

@@ -9,8 +9,8 @@ class FactoryTest extends TestCase
 {
     public function setUp()
     {
-        $this->loop = $this->getMock('React\EventLoop\LoopInterface');
-        $this->connector = $this->getMock('React\SocketClient\ConnectorInterface');
+        $this->loop = $this->getMockBuilder('React\EventLoop\LoopInterface')->getMock();
+        $this->connector = $this->getMockBuilder('React\SocketClient\ConnectorInterface')->getMock();
         $this->prober = $this->getMockBuilder('Clue\React\Quassel\Io\Prober')->disableOriginalConstructor()->getMock();
 
         $this->factory = new Factory($this->loop, $this->connector, $this->prober);

tests/FunctionalTest.php

@@ -115,7 +115,8 @@ public function testWriteClientLogin(Client $client, $message)
      */
     public function testWriteHeartBeat(Client $client)
     {
-        $time = new \DateTime();
+        // explicitly write a fixed time (current date) in order to preserve milliseconds (for PHP 7.1+)
+        $time = new \DateTime('10:20:30.456+00:00');
 
         $promise = new Promise(function ($resolve) use ($client) {
             $callback = function ($message) use ($resolve, &$callback, $client) {

tests/bootstrap.php

@@ -63,7 +63,7 @@ protected function expectCallableOnceParameter($type)
      */
     protected function createCallableMock()
     {
-        return $this->getMock('CallableStub');
+        return $this->getMockBuilder('CallableStub')->getMock();
     }
 
     protected function expectPromiseResolve($promise)