Skip to content

Commit e35481d

Browse files
committed
Update tests to remove defunct badssl.com
1 parent c201994 commit e35481d

File tree

1 file changed

+23
-6
lines changed

1 file changed

+23
-6
lines changed

tests/FunctionalTest.php

Lines changed: 23 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
use Clue\React\Socks\Client;
77
use Clue\React\Socks\Server;
88
use React\EventLoop\Loop;
9+
use React\Promise\Promise;
910
use React\Socket\Connector;
1011
use React\Socket\SecureConnector;
1112
use React\Socket\SocketServer;
@@ -440,28 +441,44 @@ public function testSecureConnectorOkay()
440441
$this->assertResolveStream($ssl->connect('www.google.com:443'));
441442
}
442443

443-
/** @group internet */
444-
public function testSecureConnectorToBadSslWithVerifyFails()
444+
public function testSecureConnectionToTlsServerWithSelfSignedCertificateFailsWithVerifyPeer()
445445
{
446446
if (!function_exists('stream_socket_enable_crypto')) {
447447
$this->markTestSkipped('Required function does not exist in your environment (HHVM?)');
448448
}
449449

450+
$socket = new SocketServer('tls://127.0.0.1:0', array(
451+
'tls' => array(
452+
'local_cert' => __DIR__ . '/../examples/localhost.pem',
453+
)
454+
));
455+
$socket->on('connection', $this->expectCallableNever());
456+
450457
$ssl = new SecureConnector($this->client, null, array('verify_peer' => true));
451458

452-
$this->assertRejectPromise($ssl->connect('self-signed.badssl.com:443'));
459+
$this->assertRejectPromise($ssl->connect($socket->getAddress()));
453460
}
454461

455-
/** @group internet */
456-
public function testSecureConnectorToBadSslWithoutVerifyWorks()
462+
public function testSecureConnectionToTlsServerWithSelfSignedCertificateWorksWithoutVerifyPeer()
457463
{
458464
if (defined('HHVM_VERSION')) {
459465
$this->markTestSkipped('Not supported on HHVM');
460466
}
461467

468+
$socket = new SocketServer('tls://127.0.0.1:0', array(
469+
'tls' => array(
470+
'local_cert' => __DIR__ . '/../examples/localhost.pem',
471+
)
472+
));
473+
$socket->on('connection', $this->expectCallableOnce());
474+
$promise = new Promise(function ($resolve) use ($socket) {
475+
$socket->on('connection', $resolve);
476+
});
477+
462478
$ssl = new SecureConnector($this->client, null, array('verify_peer' => false));
463479

464-
$this->assertResolveStream($ssl->connect('self-signed.badssl.com:443'));
480+
$this->assertResolveStream($ssl->connect($socket->getAddress()));
481+
$this->assertResolveStream($promise);
465482
}
466483

467484
/** @group internet */

0 commit comments

Comments
 (0)